Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one handler for all map_property packets #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farrainbow
Copy link
Contributor

Also move to Receive.pm and tweak unpack strings a bit.

@itsrachelfish
Copy link
Member

@farrainbow What's the best way to test this? I reviewed the code and it looks good. Do I need to go to a PVP map in order to make sure this is working?

@itsrachelfish itsrachelfish self-assigned this Jan 13, 2017
@farrainbow
Copy link
Contributor Author

Enable related config options (status_mapType, status_mapProperty) and visit different maps? PVP would be good to check since I didn't really visited one with this.

@kaliwanagan
Copy link
Contributor

I think this is good to merge; the only change I will advise is to add a message log to output the map property. This way when people start using it and just in case there are problems, their screenshots or logfiles will contain usable information.

@farrainbow what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants