Support for template parameter dependencies #21
Conversation
| @Column(columnDefinition = TEXT_COLUMN_DEFINITION, nullable = false) | ||
| @Getter | ||
| @Setter | ||
| private String placeholder; |
There was a problem hiding this comment.
Basically we want to be able to change selectExpression for parameter, depending on other parameters' values (those would be query parameters for url).
| -- | ||
|
|
||
| ALTER TABLE ONLY jasper_template_parameter_dependencies | ||
| ADD CONSTRAINT fkpxphnoksec55h63evgb3obfxq FOREIGN KEY (parameterid) REFERENCES template_parameters(id); |
There was a problem hiding this comment.
don't we want to have better constraint names?
| ); | ||
|
|
||
| -- | ||
| -- Name: jaspertemplateparameter_options fkpxphnoksec55h63evgb3obfxq; Type: FK CONSTRAINT; Schema: reports; Owner: postgres |
| @@ -323,7 +331,7 @@ public void mapRequestParametersToTemplateShouldReturnEmptyMapIfNoTemplateParame | |||
| @Test | |||
| public void mapRequestParametersToTemplateShouldReturnEmptyMapIfNoRequestParameters() { | |||
| JasperTemplateParameter templateParameter = new JasperTemplateParameter(template, PARAM1, | |||
| null, null, null, null, null, null, null, null, null); | |||
| null, null, null, null, null, null, null, null, null, null); | |||
There was a problem hiding this comment.
Can't we use no_args constructor and setters?
There was a problem hiding this comment.
@palbecki @pnaw94 I see this pull request has already been merged, but I think it's worth it to mention that even though there's the NoArgsConstructor annotation, we shouldn't use it in our code. It's there for Hibernate. I can see why the AllArgsConstructor was removed, but the NoArgs one doesn't seem to better, especially since a template parameter object should have some things set at construction time.
Ideally, we would create a constructor (or static factory method) with parameters that make sense; that seems more object-oriented.
|
@palbecki please review the newest changes. |
This change is