Fix timeout cast exception #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
reviewed
Jan 6, 2022
There was a problem hiding this comment.
Should we check that it is a long before calling Long.valueOf()? We have code in DevTask that checks isInteger() before calling toInteger() on the server.timeout.
Updated: Now that I look at the String documentation, I don't even see an isInteger() or toInteger() method and I think DevTask would get a failure at line 927:
|
Still want me to add a check for that? Or should we just let it fail on bad plugin config? |
cherylking
requested changes
Jan 13, 2022
| @@ -925,7 +925,12 @@ class DevTask extends AbstractFeatureTask { | |||
|
|
|||
| if (serverStartTimeout == null) { | |||
| if (server.timeout != null && server.timeout.isInteger()) { | |||
| serverStartTimeout = server.timeout.toInteger(); | |||
| try { | |||
There was a problem hiding this comment.
I don't believe isInteger() is valid on the line before this either. Probably should just check that the string is notEmpty().
There was a problem hiding this comment.
Yeah, missed that. Fixed it.
cherylking
approved these changes
Jan 13, 2022
jjiwooLim
pushed a commit
to jjiwooLim/ci.gradle
that referenced
this pull request
Jan 24, 2022
* Fix timeout cast exception * Catch NumberFormatException for bad long value * Update error message * Update server parameter casts in DevTask * Check for empty server.timeout value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #684