Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide json file dependency for user feature #691

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

jjiwooLim
Copy link
Contributor

fixes #667
Instead of creating a new instance of gradle, use the file dependency configuration from prepareFeature task

@jjiwooLim
Copy link
Contributor Author

Restored gradle.yml to use ci.common main branch

@cherylking
Copy link
Member

@jjiwooLim Please do not merge this until you resolve the compilation error:

/home/runner/work/ci.gradle/ci.gradle/src/main/groovy/io/openliberty/tools/gradle/tasks/AbstractPrepareTask.groovy: 89: Method 'provideJsonFileDependency' from class 'io.openliberty.tools.gradle.tasks.AbstractPrepareTask$PrepareFeatureTaskUtil' does not override method from its superclass or interfaces but is annotated with @Override.
 @ line 89, column 3.
   		@Override

@jjiwooLim
Copy link
Contributor Author

@jjiwooLim Please do not merge this until you resolve the compilation error:

/home/runner/work/ci.gradle/ci.gradle/src/main/groovy/io/openliberty/tools/gradle/tasks/AbstractPrepareTask.groovy: 89: Method 'provideJsonFileDependency' from class 'io.openliberty.tools.gradle.tasks.AbstractPrepareTask$PrepareFeatureTaskUtil' does not override method from its superclass or interfaces but is annotated with @Override.
 @ line 89, column 3.
   		@Override

After merging ci.common PR, the compilation errors were resolved.

@jjiwooLim jjiwooLim merged commit 6bd77dd into OpenLiberty:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user feature install fails with Gradle 7
3 participants