Fix loose app generation for jar project dependencies in war projects #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbsox
force-pushed
the
loose-war-with-loose-jar-fix
branch
from
bafd6d4
to
ae4ab29
Compare
cherylking
previously approved these changes
Mar 2, 2023
...urces/loose-war-with-loose-jar/ejb-ejb/src/main/java/wasdev/ejb/ejb/SampleStatelessBean.java
Outdated
Show resolved
Hide resolved
.../resources/loose-war-with-loose-jar/ejb-war/src/main/java/wasdev/ejb/ejb/web/EJBServlet.java
Outdated
Show resolved
Hide resolved
|
I just noticed that all the failing builds are Java 8. Is there something to that? I didn't look at the build logs yet. |
mattbsox
force-pushed
the
loose-war-with-loose-jar-fix
branch
from
ae4ab29
to
c7f1e89
Compare
cherylking
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loose app xml files for war files will now include an archive element for jar project dependencies.