-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in keystore_password in target server.env if present #1097
Conversation
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
2488a1f
to
b089857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good. I just wonder if we need some consensus that this change is appropriate (YK, Eric, etc.). Also, if we make this change here, then we need to update Gradle the same way.
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Outdated
Show resolved
Hide resolved
Thx for the review @cherylking .. will wait to get more opinions: @yeekangc @ericglau if this change seems OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. Overall it looks fine to me.
@cherylking I think it'd be OK to fix this in Maven, merge, open a ci.gradle issue but fix later. I don't think anyone would soon complain about this as an inconsistency across Maven vs. Gradle. I know .. there's always the risk that it just sits there and doesn't get done. But what do you think? |
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
a620cbc
to
443b0f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Please open a ci.gradle issue to implement this same functionality. Also, can you open a ci.maven issue to add tests for this? I see you did manual tests, but we should have a couple integration tests for this.
Gradle issue: OpenLiberty/ci.gradle#587 |
Signed-off-by: Scott Kurz skurz@us.ibm.com
Fixes #1096
Note the change is a no-op if you have either a server.env in configDir or a serverEnvFile parm configured.
Manual test checklist