-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Consuming JSON Web Tokens in Liberty to Open Liberty #6024
Comments
Initial peer reviewConstruct JWT for an applicationIn the description for this example, the code attribute is listed as CHANGE The Configure the JWT consumerThe 1st example here is misleading, no element will exist unless the user adds one, but the default will apply regardless. Instead of showing an example that has no function, we can just describe the default behavior. Remove the example and make the following change. CHANGE When you add the jwt-1.0 feature and save your changes, Open Liberty adds the following default jwtConsumer element. In this default configuration, the following values are assumed. (bulleted list) ---> When the JSON Web Token feature is enabled, Open Liberty creates a default configuration with the following values.
You can reconfigure these defaults by specifying a before the next example, need to fix bulleted list by adding a blank line preceding. Also, make this into an ordered list since these are two sequential steps. Text here looks good otherwise. Verify and parse JWT tokens in your applicationCHANGE The following example shows how to programmatically verify and parse... |
Thanks David! Comments have been incorporated. |
Hi Hilton, this looks good. Just a few more suggestions
The following example shows how to configure the server for constructing a JSON Web Token (JWT) for an application. Configure the JWT consumerPlease compare your current draft with my previous suggestion. The first two sentences still need work. The feature should use the text name rather than the code name with version so that the content remains current when a new version is released. Also, the link to the config element is redundant at the top as you have added it in the following paragraph. CHANGE When you add the jwt-1.0 feature and save your changes, Open Liberty adds the jwtConsumer element. For information about jwtConsumer attributes that you can configure, see JWT consumer. ---> When the JSON Web Token feature is enabled, Open Liberty creates a default configuration with the following values. |
Hi Hilton- one more change- the list of default settings is introduced twice, please remove the second redundant introduction. When the JSON Web Token feature is enabled, Open Liberty creates a default configuration with the following values.
|
Incorporated comments. |
Hi @teddyjtorres , can you review the doc for this issue, which migrates information about using the Open Liberty docs draft: https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/reference/feature/jwt-1.0.html WebSphere Liberty doc source for this information: Consuming JSON Web Tokens in Liberty |
Thank you for this documentation. There are 2 minors changes suggested. Please change,
so that the attributes match the order in which they are explained in the paragraph. Please change, The expiry attribute indicates the token expiration time, which is 600 seconds. |
#6024 Incorporated comments from Teddy.
@teddyjtorres Thanks for the review. I have incorporated your comments. |
migrate the topic Consuming JSON Web Tokens in Liberty to jwt feature page.
Include the updates specified in https://github.ibm.com/websphere/liberty-docs/issues/3200
The text was updated successfully, but these errors were encountered: