Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update absoluteWLPPath in testStartInContainerActionUsingPlayToolbarButton() test #1079

Merged

Conversation

anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Nov 6, 2024

Fixes #1078 #564

As part of Issue 564, container tests were previously disabled. However, recent testing has confirmed that the underlying issue no longer occurs, and these Devc tests no longer cause failures in other test cases. Therefore, this PR re-enables the container tests.

turkeylurkey
turkeylurkey previously approved these changes Nov 7, 2024
Copy link
Member

@turkeylurkey turkeylurkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the pull request.

@anusreelakshmi934
Copy link
Contributor Author

Please update the pull request.

I have updated the description of this PR to include the issues it addresses.

Copy link
Member

@turkeylurkey turkeylurkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand now, looks good.

@anusreelakshmi934 anusreelakshmi934 merged commit 4fcebfe into OpenLiberty:main Nov 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the absoluteWLPPath in the testStartInContainerActionUsingPlayToolbarButton test.
4 participants