-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated UI tests for case insensitive matching of completion items #1203
Add automated UI tests for case insensitive matching of completion items #1203
Conversation
Recording of the test testInsertLibertyConfigIntoServerEnvForLowerCase.movRecording of the test testInsertLibertyConfigIntoServerEnvForMixOfCases.movRecording of the test testInsertLibertyConfigIntoBootstrapPropsForCapitalCase.movRecording of the test testInsertLibertyConfigIntoBootstrapPropsForMixOfCases.mov |
src/test/java/io/openliberty/tools/intellij/it/SingleModLibertyLSTestCommon.java
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/intellij/it/UIBotTestUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggested change related to the use of String.toUpperCase() / String.toLowerCase(). Ensures that capitalization rules are applied consistently regardless of the environment (locale) that the tests are run in.
src/test/java/io/openliberty/tools/intellij/it/UIBotTestUtils.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Michael Glavassevich <mrglavas@ca.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaisakhkannan Looks good. Thanks for providing the videos with the PR. Watching them was very helpful to understand the scenarios being tested here and also demonstrated that they work correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes #953
Added four more automated UI tests to verify matching completion items in the server.env and bootstrap.properties files.
Current Scenarios we have right now:
I have added 4 more scenarios. Below are the 4 scenarios, and I have added tests for them, so they are included in this PR.