Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated UI tests for case insensitive matching of completion items #1203

Conversation

vaisakhkannan
Copy link
Contributor

@vaisakhkannan vaisakhkannan commented Dec 19, 2024

Fixes #953
Added four more automated UI tests to verify matching completion items in the server.env and bootstrap.properties files.

Current Scenarios we have right now:

  • Full capital case letters insert into server.env
  • Full lowercase letters insert into bootstrap.properties

I have added 4 more scenarios. Below are the 4 scenarios, and I have added tests for them, so they are included in this PR.

  1. Full lowercase letters insert into server.env
  2. A mix of lowercase and capital case letters insert into server.env
  3. Full capital case letters insert into bootstrap.properties
  4. A mix of lowercase and capital case letters insert into bootstrap.properties

@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Dec 19, 2024

Recording of the test testInsertLibertyConfigIntoServerEnvForLowerCase

testInsertLibertyConfigIntoServerEnvForLowerCase.mov

Recording of the test testInsertLibertyConfigIntoServerEnvForMixOfCases

testInsertLibertyConfigIntoServerEnvForMixOfCases.mov

Recording of the test testInsertLibertyConfigIntoBootstrapPropsForCapitalCase

testInsertLibertyConfigIntoBootstrapPropsForCapitalCase.mov

Recording of the test testInsertLibertyConfigIntoBootstrapPropsForMixOfCases

testInsertLibertyConfigIntoBootstrapPropsForMixOfCases.mov

dessina-devasia
dessina-devasia previously approved these changes Jan 1, 2025
Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested change related to the use of String.toUpperCase() / String.toLowerCase(). Ensures that capitalization rules are applied consistently regardless of the environment (locale) that the tests are run in.

…java

Co-authored-by: Michael Glavassevich <mrglavas@ca.ibm.com>
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaisakhkannan Looks good. Thanks for providing the videos with the PR. Watching them was very helpful to understand the scenarios being tested here and also demonstrated that they work correctly.

Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vaisakhkannan vaisakhkannan merged commit c0525b4 into OpenLiberty:main Jan 7, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP4iJ: Develop automated UI tests for case insensitive matching of completion items.
3 participants