Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run builds for those PRs which do not contain a merge conflict - Issue #845 #851

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Run builds for those PRs which do not contain a merge conflict - Issue #845 #851

merged 5 commits into from
Jul 9, 2024

Conversation

anusreelakshmi934
Copy link
Contributor

Fixes #845

@anusreelakshmi934
Copy link
Contributor Author

Since redhat-developer/lsp4ij currently do not have any PR without merge commit, that step is skipped here and only main branch is running.
Here is the cron job workflow file - https://github.com/anusreelakshmi934/liberty-tools-intellij/actions/runs/9772662447

@anusreelakshmi934 anusreelakshmi934 linked an issue Jul 3, 2024 that may be closed by this pull request
Run LTI tests for LSP4IJ PRs only if they do not contain a merge conflict. #845
Closed
vaisakhkannan
vaisakhkannan requested changes Jul 3, 2024
View reviewed changes
.github/workflows/cronJob.yaml Show resolved Hide resolved
.github/workflows/cronJob.yaml Outdated Show resolved Hide resolved
.github/workflows/cronJob.yaml Show resolved Hide resolved
mrglavas
mrglavas previously approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

vaisakhkannan
vaisakhkannan previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.Thanks

mrglavas
mrglavas previously approved these changes Jul 4, 2024
View reviewed changes
@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Jul 5, 2024 •
edited
Loading

Links are displayed for both clean and conflicted PRs. Currently lsp4ij doesnt have any clean PR. So displaying conflicted PR warning only.
image

@anusreelakshmi934
Copy link
Contributor Author

Attaching Screenshot for reference on how it will look in case of PRs without conflict. This is liberty-tools-vscode repo.
image

aparnamichael
aparnamichael approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mrglavas
mrglavas approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the links to the PRs.

@anusreelakshmi934 anusreelakshmi934 merged commit 4ff320b into OpenLiberty:lsp4ij-market-0.0.2-integration Jul 9, 2024
2 of 3 checks passed
@anusreelakshmi934 anusreelakshmi934 deleted the Issue#845 branch August 28, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparnamichael aparnamichael aparnamichael approved these changes

@mrglavas mrglavas mrglavas approved these changes

@vaisakhkannan vaisakhkannan vaisakhkannan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run LTI tests for LSP4IJ PRs only if they do not contain a merge conflict.
4 participants
@anusreelakshmi934 @mrglavas @aparnamichael @vaisakhkannan