Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference is not serialized correctly #1929

Closed
leochr opened this issue Jan 31, 2018 · 1 comment
Closed

Reference is not serialized correctly #1929

leochr opened this issue Jan 31, 2018 · 1 comment
Assignees
Labels
bug This bug is not present in a released version of Open Liberty in:MicroProfile/OpenAPI

Comments

@leochr
Copy link
Member

leochr commented Jan 31, 2018

Reference when serialized uses 'ref'. But it should be '$ref' as per the spec (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#referenceObject)

Sample output:

      summary: TEST SUMMARY
      operationId: getTestFlights
      parameters:
      - ref: '#/components/parameters/departureDate'

It should be
- $ref: '#/components/parameters/departureDate'

This issue probably affects all referenceable items (not just parameters) except for Schema (which is serialized correctly). Probably due to Schema having it's own serializer.

This was observed with the output produced by the the model reader app from the TCK (org.eclipse.microprofile.openapi.reader.MyOASModelReaderImpl).

@leochr leochr added bug This bug is not present in a released version of Open Liberty in:MicroProfile/OpenAPI labels Jan 31, 2018
@leochr leochr self-assigned this Feb 1, 2018
leochr added a commit to leochr/open-liberty that referenced this issue Feb 1, 2018
@leochr
Copy link
Member Author

leochr commented Feb 7, 2018

merged

@leochr leochr closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This bug is not present in a released version of Open Liberty in:MicroProfile/OpenAPI
Projects
None yet
Development

No branches or pull requests

1 participant