Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14 fix invalid attributes and mutliple withData #15

Closed
wants to merge 2 commits into from
Closed

14 fix invalid attributes and mutliple withData #15

wants to merge 2 commits into from

Conversation

amylin1
Copy link
Contributor

@amylin1 amylin1 commented Sep 19, 2017

For issue#14

@LibbyBot
Copy link

LibbyBot commented Sep 19, 2017 •
edited
Loading

Please code review, @OpenLiberty/reviewer

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 6 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@amylin1
Copy link
Contributor Author

amylin1 commented Sep 19, 2017

#build

@LibbyBot
Copy link

I cannot process this build request due to one or both of the following:

  • The comment author is not a member of the organization.
  • The pull request creator did not send a signed CLA.

@amylin1
Copy link
Contributor Author

amylin1 commented Sep 19, 2017

I have run unit tests, microprofile health TCK tests and also manual tests for my changes

@amylin1
Copy link
Contributor Author

amylin1 commented Sep 19, 2017

#build

@LibbyBot
Copy link

I cannot process this build request due to one or both of the following:

  • The comment author is not a member of the organization.
  • The pull request creator did not send a signed CLA.

@amylin1
Copy link
Contributor Author

amylin1 commented Sep 19, 2017

bd1ea8ec8aa0357414e8-e7b55cd3326eb4efda7d1252a256306c22adff26.zip

@amylin1
Copy link
Contributor Author

amylin1 commented Sep 19, 2017

Just sent signed CLA

@amylin1
Copy link
Contributor Author

amylin1 commented Sep 19, 2017

#build

@LibbyBot
Copy link

I cannot process this build request due to one or both of the following:

  • The comment author is not a member of the organization.
  • The pull request creator did not send a signed CLA.

@amylin1 amylin1 closed this Sep 19, 2017
@amylin1 amylin1 reopened this Sep 19, 2017
@amylin1 amylin1 closed this Sep 19, 2017
leochr pushed a commit to leochr/open-liberty that referenced this pull request Feb 1, 2018
@arturdzm
Merge pull request OpenLiberty#15 from janamanoharan/reader
59488b3 
added reader changes
herman-kailey added a commit to herman-kailey/open-liberty that referenced this pull request Oct 17, 2019
@herman-kailey
Merge pull request OpenLiberty#15 from herman-kailey/mavenRepo
1a69f4b 
Add support for download action with AssetIds
brenthdaniel added a commit to brenthdaniel/open-liberty that referenced this pull request Jul 11, 2022
@brenthdaniel
Merge pull request OpenLiberty#15 from brenthdaniel/updateMacReadme
af48ab8 
Update OSX documentation to recommend installing odcs and brew
mrsaldana pushed a commit to mrsaldana/open-liberty that referenced this pull request Apr 29, 2024
@isaacrivriv
Merge pull request OpenLiberty#15 from mrsaldana/netty-redirect-secur…
a712f6d 
…ity-oidc-fixes

Redirect changes to address some of the redirect issues in security.oidc
jacobwdv pushed a commit to jacobwdv/open-liberty that referenced this pull request Dec 3, 2024
@mshah0722
Merge pull request OpenLiberty#15 from utle/FIPSwork
1a9e43e 
Undo changes for LogPolice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Needed release-18.0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amylin1 @LibbyBot