-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oidc JWE FAT delivery #2 #17495
Oidc JWE FAT delivery #2 #17495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes.
@@ -382,3 +382,7 @@ JWE_REQUIRED_BUT_TOKEN_NOT_JWE.useraction=To accept JWS tokens instead of JWE to | |||
NESTED_JWS_REQUIRED_BUT_NOT_FOUND=CWWKS6065E: The payload of the JSON Web Encryption (JWE) token that is included in the request is not a JSON Web Signature (JWS) token. | |||
NESTED_JWS_REQUIRED_BUT_NOT_FOUND.explanation=The payload of a JWE token must be a valid JSON Web Token (JWT) in JWS format. | |||
NESTED_JWS_REQUIRED_BUT_NOT_FOUND.useraction=Ensure that the payload of the JWE token is a valid JWT in JWS format. | |||
|
|||
JWE_DECRYPTION_KEY_MISSING=CWWKS6066E: The JSON Web Encryption (JWE) token cannot be decrypted because a decryption key cannot be found. The {0} server configuration attribute is set to [{1}]. | |||
JWE_DECRYPTION_KEY_MISSING.explanation=A decryption key is required to decrypt the JWE token. The decryption key must be present in the key store that is configured for the JWT consumer, or the key must be specified in MicroProfile Config properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change "key store" to "keystore" (1 word)
- Put "the" before "MicroProfile Config properties"
The decryption key must be present in the keystore that is configured for the JWT consumer, or the key must be specified in the MicroProfile Config properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adam made the changes under 17511 - my pull had drug his product changes along for the ride.
We've now separated things...
|
||
JWE_DECRYPTION_KEY_MISSING=CWWKS6066E: The JSON Web Encryption (JWE) token cannot be decrypted because a decryption key cannot be found. The {0} server configuration attribute is set to [{1}]. | ||
JWE_DECRYPTION_KEY_MISSING.explanation=A decryption key is required to decrypt the JWE token. The decryption key must be present in the key store that is configured for the JWT consumer, or the key must be specified in MicroProfile Config properties. | ||
JWE_DECRYPTION_KEY_MISSING.useraction=Verify that the key alias that is specified in the message exists in the key store that is configured for the JWT consumer. If the alias is not configured, the decryption key must be specified in MicroProfile Config properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Same as previous comment: Use "keystore" and "the MicroProfile Config properties."
- Unless the wording "the keystore that is configured for the JWT consumer" is needed for clarity, shorten the wording to "the JWT consumer keystore."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adam made the changes under 17511 - my pull had drug his product changes along for the ride.
We've now separated things...
L2 message review completed |
#run-libby-bot |
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/__Ge_oM1EEeu6B9yc149Q8g Target locations of links might be accessible only to IBM employees. |
Your Open Liberty build results are ready for viewing.
|
The build c00crane-17495-20210614-1326 For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=__Ge_oM1EEeu6B9yc149Q8g |
#run-libby-bot |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_A6PV0M4BEeu6B9yc149Q8g Target locations of links might be accessible only to IBM employees. |
Your Open Liberty build results are ready for viewing.
|
The build c00crane-17495-20210615-1904 |
#libby |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Deliver FAT tests to verify support for JWT Tokens by the OIDC RP