New JSP option javaSourceLevel #18359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epj
added
in:Web Components
release bug
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
epj
force-pushed
the
7183-javaSourceLevel
branch
3 times, most recently
from
9b3107e to
1f5cd4f
Compare
pnicolucci
reviewed
Aug 3, 2022
| useJavaSourceLevel = Integer.parseInt(rawJavaSourceLevel); | ||
| } catch(NumberFormatException e) { | ||
| if (com.ibm.ejs.ras.TraceComponent.isAnyTracingEnabled() && logger.isLoggable(Level.INFO)) { | ||
| logger.logp(Level.INFO, CLASS_NAME, "populateOptions", "Invalid value for javaSourceLevel = " + rawJavaSourceLevel + "."); |
There was a problem hiding this comment.
This INFO message should be translated.
pnicolucci
reviewed
Aug 3, 2022
| if (javaSourceLevel > jmv) { | ||
| // can not specify higher than running Java | ||
| if (com.ibm.ejs.ras.TraceComponent.isAnyTracingEnabled() && logger.isLoggable(Level.INFO)) { | ||
| logger.logp(Level.INFO, CLASS_NAME, "setJavaSourceLevel", "Requested javaSourceLevel=" + javaSourceLevel + |
pnicolucci
reviewed
Aug 3, 2022
| @@ -1618,6 +1649,7 @@ public String toString() { //overrride Object's toString to assist in debugging. | |||
| "ieClassId = [" + ieClassId +"]"+separatorString+ | |||
| "isZOS = [" + isZOS +"]"+separatorString+ | |||
| "javaEncoding = [" + javaEncoding +"]"+separatorString+ | |||
| "javaSourceLevel = [" + javaSourceLevel +"]"+separatorString+ | |||
There was a problem hiding this comment.
Translate and also try to come up with a better message for:
logger.logp(Level.INFO, CLASS_NAME, "setJdkSourceLevel", "Requested jdkSourceLevel=" + jdkSourceLevel +
", but forcing to 17 because it is the min supported by Java 12+");
57711fe to
6731d7e
Compare
epj
force-pushed
the
7183-javaSourceLevel
branch
from
6731d7e to
4b1e32f
Compare
|
closed in favor of #25494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #25494