Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated JsonP 2.1.0 tck tests #20960

Merged
merged 7 commits into from
May 10, 2022
Merged

Automated JsonP 2.1.0 tck tests #20960

merged 7 commits into from
May 10, 2022

Conversation

tabishop
Copy link
Contributor

Added automated JsonP 2.1.0 tck tests

@tabishop tabishop requested a review from KyleAure April 28, 2022 19:52
@tabishop
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ptuw4MfgEeyhmZ5zGPuLaA

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build tabishop-20960-20220429-1127
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ptuw4MfgEeyhmZ5zGPuLaA
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_ptuw4MfgEeyhmZ5zGPuLaA

KyleAure
KyleAure reviewed May 3, 2022
View reviewed changes
dev/io.openliberty.jakarta.jsonp.2.1_fat_tck/publish/tckRunner/tck/pom.xml Outdated
Comment on lines 137 to 157
<!-- Plugin used to internal bundles to signaturedirectory for signature tests -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<version>3.0.0</version>
<executions>
<execution>
<id>copy-jsonp</id>
<phase>generate-test-sources</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<target>
<!-- <copy file="${io.openliberty.jakarta.jsonp.3.0}" tofile="${project.build.directory}/signaturedirectory/jakarta.json.bind-api.jar"/> -->
<copy file="${io.openliberty.jakarta.jsonp.2.1}" tofile="${project.build.directory}/signaturedirectory/jakarta.json-api.jar"/>
</target>
</configuration>
</execution>
</executions>
</plugin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have accidentally deleted both of these plugins, when only one needed to be removed.
We should be using the plugin with:

@KyleAure
Copy link
Member

KyleAure commented May 3, 2022

The build tabishop-20960-20220429-1127 https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ptuw4MfgEeyhmZ5zGPuLaA completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_ptuw4MfgEeyhmZ5zGPuLaA

This build showed failures in the Signature tests:

ee.jakarta.tck.jsonp.signaturetest.SigTestEE$Fault: JSONPSigTest.signatureTest() failed!, diffs found

because of #20960 (comment)

This build also showed a failure in our test infrastructure

java.lang.Throwable: 2022-04-29-17:47:35:138 An invalid XML character (Unicode: 0xffff) was found in the CDATA section.
	at componenttest.custom.junit.runner.FATRunner.newThrowableWithTimeStamp(FATRunner.java:295)

This can likely be fixed by introducing this change: https://github.com/OpenLiberty/open-liberty/pull/20866/files#diff-1335108c4d715750ac4218db4469c1f059d360c70d987d401a8992f3f3f01110R777-R786

KyleAure
KyleAure requested changes May 3, 2022
View reviewed changes
dev/io.openliberty.jakarta.jsonp.2.1_fat_tck/publish/tckRunner/tck/pom.xml Outdated
Comment on lines 41 to 42
<jakarta.json.version>2.1.0-SNAPSHOT</jakarta.json.version>
<jakarta.json.tck.version>2.1.0-SNAPSHOT</jakarta.json.tck.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to update these to 2.1.0. The stagging repo has been fixed as of this fix: https://www.eclipse.org/lists/jsonp-dev/msg00074.html

KyleAure
KyleAure reviewed May 3, 2022
View reviewed changes
...rty.jakarta.jsonp.2.1_fat_tck/fat/src/io/openliberty/jakarta/jsonp/tck/JsonpTckLauncher.java Outdated
} else {
additionalProps.put("exclude.tests", "ee.jakarta.tck.jsonp.api.provider.JsonProviderTest.java");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the conversation here: jakartaee/jsonp-api#376 (comment)
I think you can avoid excluding this test by running each test package within its own VM. An example on how to accomplish this is here: https://github.com/eclipse-ee4j/jsonp/blob/master/tck/tck-dist-eftl/src/main/bin/pom.xml#L125-L126

@tabishop
Copy link
Contributor Author

tabishop commented May 9, 2022

#build

@LibbyBot
Copy link

LibbyBot commented May 9, 2022

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_bCyYQM-oEeyhmZ5zGPuLaA

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@tabishop tabishop force-pushed the 19402-create-jsonp-2.1-feature branch from 1f4350b to 088e537 Compare May 9, 2022 18:38
KyleAure
KyleAure approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@KyleAure KyleAure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! 👍🏼

@tabishop
Copy link
Contributor Author

tabishop commented May 9, 2022

#build

@LibbyBot
Copy link

LibbyBot commented May 9, 2022

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CXHScM_ZEeyhmZ5zGPuLaA

Target locations of links might be accessible only to IBM employees.

@tabishop
Copy link
Contributor Author

#libbybot

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • Please describe in a separate comment how you tested your changes.

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 12 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

The build tabishop-20960-20220509-1454
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CXHScM_ZEeyhmZ5zGPuLaA
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_CXHScM_ZEeyhmZ5zGPuLaA

@tabishop
Copy link
Contributor Author

Errors in personal build are not related to the changes in this PR and are associated with a separate defect.

@tabishop tabishop merged commit 89702c4 into OpenLiberty:integration May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAure KyleAure KyleAure approved these changes

Assignees
No one assigned
Labels
CLA Signed noproductcode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabishop @LibbyBot @KyleAure