Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24157: Validate header names #24187

Merged
merged 4 commits into from
Feb 10, 2023
Merged

24157: Validate header names #24187

merged 4 commits into from
Feb 10, 2023

Conversation

loriadi
Copy link
Contributor

@loriadi loriadi commented Feb 3, 2023

fixes #24157

@loriadi
Copy link
Contributor Author

loriadi commented Feb 3, 2023

#build

@loriadi loriadi self-assigned this Feb 3, 2023
@LibbyBot
Copy link

LibbyBot commented Feb 3, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_trpCYKQSEe23HdxJAjh3dw

Target locations of links might be accessible only to IBM employees.

@loriadi loriadi force-pushed the 24157-headerValidaiton branch from ac140af to fb8fad6 Compare February 5, 2023 15:44
@loriadi
Copy link
Contributor Author

loriadi commented Feb 5, 2023

#build

@LibbyBot
Copy link

LibbyBot commented Feb 5, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FM2u0KVkEe24er7gxU0d3Q

Target locations of links might be accessible only to IBM employees.

@loriadi
Copy link
Contributor Author

loriadi commented Feb 6, 2023

#build

@LibbyBot
Copy link

LibbyBot commented Feb 6, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Wz-IsKYjEe24er7gxU0d3Q

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 6, 2023

The build loriadi-24187-20230205-2032
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_74BckKSWEe24er7gxU0d3Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_74BckKSWEe24er7gxU0d3Q

@loriadi
Copy link
Contributor Author

loriadi commented Feb 7, 2023

#build

@loriadi
Copy link
Contributor Author

loriadi commented Feb 7, 2023

#libbybot

@LibbyBot
Copy link

LibbyBot commented Feb 7, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_isKskKcREe24er7gxU0d3Q

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 8, 2023

The build loriadi-24187-20230207-1110
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_isKskKcREe24er7gxU0d3Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_isKskKcREe24er7gxU0d3Q

@loriadi loriadi force-pushed the 24157-headerValidaiton branch from fb8fad6 to bc2b7a5 Compare February 8, 2023 21:06
@loriadi
Copy link
Contributor Author

loriadi commented Feb 8, 2023

#build

@loriadi
Copy link
Contributor Author

loriadi commented Feb 8, 2023

#libbybot

@LibbyBot
Copy link

LibbyBot commented Feb 8, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_7ZimYKfvEe24er7gxU0d3Q

Target locations of links might be accessible only to IBM employees.

@loriadi
Copy link
Contributor Author

loriadi commented Feb 9, 2023 •
edited
Loading

All the errors from the build are this:
java.lang.IllegalStateException: Could not find a valid Docker environment. Please see logs and check configuration

and other builds surrounding my build have these same errors. My changes did not cause this error.

I've added a couple of unit tests and also tested this change manually with a trace logging enabled.

@loriadi loriadi requested a review from mrsaldana February 9, 2023 15:57
@loriadi loriadi force-pushed the 24157-headerValidaiton branch from bc2b7a5 to 1329a89 Compare February 9, 2023 22:14
@loriadi
Copy link
Contributor Author

loriadi commented Feb 9, 2023

#build

@loriadi
Copy link
Contributor Author

loriadi commented Feb 9, 2023

#libbybot

@LibbyBot
Copy link

LibbyBot commented Feb 9, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_IHkPwKjCEe24er7gxU0d3Q

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Feb 9, 2023

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

The build loriadi-24187-20230208-1341
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_7ZimYKfvEe24er7gxU0d3Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_7ZimYKfvEe24er7gxU0d3Q

@loriadi
Copy link
Contributor Author

loriadi commented Feb 10, 2023

fixes #PH52074

mrsaldana
mrsaldana approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@mrsaldana mrsaldana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work !

@LibbyBot
Copy link

The build loriadi-24187-20230209-1514
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_IHkPwKjCEe24er7gxU0d3Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_IHkPwKjCEe24er7gxU0d3Q

@loriadi loriadi merged commit 934ad4b into OpenLiberty:integration Feb 10, 2023
@jhanders34 jhanders34 mentioned this pull request Feb 19, 2023
Merged
@jhanders34 jhanders34 mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsaldana mrsaldana mrsaldana approved these changes

Assignees

@loriadi loriadi

Labels
CLA Signed in:Transport team:Sirius
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate HTTP header names
3 participants
@loriadi @LibbyBot @mrsaldana