Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yoko to allow IDL string chars > 127 #25418

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Update yoko to allow IDL string chars > 127 #25418

merged 1 commit into from
Jun 10, 2023

Conversation

joe-chacko
Copy link
Member

fixes #25352

@joe-chacko joe-chacko requested a review from ngmr June 5, 2023 21:45
@joe-chacko
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Jun 5, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_9SuWoAPmEe6Gnsx4pF5sWA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Jun 5, 2023

Joe's DHE check:

✔️ I found your oss_ibm.maven GAV artifacts on DHE. Thank you! ✔️

@joe-chacko joe-chacko force-pushed the update-yoko-idl-string-fix branch from 29879f5 to 08308e1 Compare June 9, 2023 15:13
@joe-chacko
Copy link
Member Author

#build #run-libby-bot

@LibbyBot
Copy link

LibbyBot commented Jun 9, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8fbtgAbQEe6Gnsx4pF5sWA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Jun 9, 2023

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 6 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Jun 9, 2023

Joe's DHE check:

✔️ I found your oss_ibm.maven GAV artifacts on DHE. Thank you! ✔️

@LibbyBot
Copy link

The build joe-chacko-25418-20230609-0836
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8fbtgAbQEe6Gnsx4pF5sWA
completed successfully!

ngmr
ngmr approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@ngmr ngmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ngmr ngmr merged commit 64fa94e into OpenLiberty:integration Jun 10, 2023
pmd1nh pushed a commit to pmd1nh/open-liberty that referenced this pull request Jun 12, 2023
@ngmr @pmd1nh
Merge pull request OpenLiberty#25418 from joe-chacko/update-yoko-idl-…
a5178c7 
…string-fix

Update yoko to allow IDL string chars > 127
@joe-chacko joe-chacko deleted the update-yoko-idl-string-fix branch August 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngmr ngmr ngmr approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

org.omg.CORBA.DATA_CONVERSION: illegal char value for string
3 participants
@joe-chacko @LibbyBot @ngmr