Remove Audit Rest API invokation #27692
Conversation
|
Support message review not required. |
wrodrig
force-pushed
the
audit-rest
branch
4 times, most recently
from
a361616 to
4b1ea4a
Compare
There was a problem hiding this comment.
I didn't update every file that had the same issues, so if you see a comment, you may want to also look at the other files to see if the problem is there as well. Additional things to look at / fix:
- Update copyright date in files
- Update your IDE to use 4 spaces for indentation instead of tabs. It really makes it hard to read the code when you have 8 character tabs.
- Instead of repeating the FATSuite with audit-2.0, it will be better to do it for the individual test especially when only 1 or 2 tests in a FATSuite actually test with audit. Doing the repeat has no value on those tests that aren't using the audit-1.0 feature.
- I don't think it is right to add the restConnector feature to the list of features when switching from audit 1.0 to 2.0. I think you should just add audit-2.0 in the FeatureReplacementAction.
- I think it is overkill to add in the audit common.tooling for doing the FeatureReplacementAction. In light of
#4it is just audit-1.0 to audit-2.0. No reason to bring in the common.tooling for constants to be used for the FeatureReplacementAction.
dev/com.ibm.websphere.appserver.features/visibility/auto/io.openliberty.audit2.0.feature
Outdated
Show resolved
Hide resolved
...m.websphere.appserver.features/visibility/auto/io.openliberty.security.audit2.0.rest.feature
Outdated
Show resolved
Hide resolved
...pserver.features/visibility/protected/com.ibm.websphere.appserver.auditCollector-2.0.feature
Outdated
Show resolved
Hide resolved
...appserver.features/visibility/public/audit-2.0/com.ibm.websphere.appserver.audit-2.0.feature
Outdated
Show resolved
Hide resolved
...pserver.features/visibility/protected/com.ibm.websphere.appserver.auditCollector-2.0.feature
Outdated
Show resolved
Hide resolved
...quest.probe.audit.servlet/src/com/ibm/ws/request/probe/audit/servlet/AuditPERestService.java
Outdated
Show resolved
Hide resolved
....config_fat/fat/src/com/ibm/ws/rest/handler/config/fat/audit/ConfigRESTHandlerAuditTest.java
Outdated
Show resolved
Hide resolved
...urity.audit.source.rest/src/com/ibm/ws/security/audit/source/rest/MemberManagementEvent.java
Outdated
Show resolved
Hide resolved
....config_fat/fat/src/com/ibm/ws/rest/handler/config/fat/audit/ConfigRESTHandlerAuditTest.java
Outdated
Show resolved
Hide resolved
dev/com.ibm.ws.rest.handler.config_fat/fat/src/com/ibm/ws/rest/handler/config/fat/FATSuite.java
Outdated
Show resolved
Hide resolved
wrodrig
force-pushed
the
audit-rest
branch
9 times, most recently
from
f0de8d7 to
2ba2740
Compare
|
#build |
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
|
The build wrodrig-27692-20240520-1730 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_dM4k0BbFEe-aC7a28EbkCw |
|
#build |
|
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=2d75f6ac-8af4-4aa3-8565-d7f3610b64fc Target locations of links might be accessible only to IBM employees. |
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_vtck0BeoEe-aC7a28EbkCw Target locations of links might be accessible only to IBM employees. |
|
The build wrodrig-27692-20240521-0436 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_BqR94BblEe-aC7a28EbkCw |
|
#build |
| @@ -282,6 +282,8 @@ private static Set<String> getExtendedCompatibleFeatures(Set<String> compatibleF | |||
| // remove logAnalysis-1.0. It depends on hpel being configured | |||
| features.remove("logAnalysis-1.0"); | |||
|
|
|||
| feature.remove("audit-2.0"); | |||
There was a problem hiding this comment.
| feature.remove("audit-2.0"); | |
| features.remove("audit-2.0"); |
This is what caused your build break.
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
|
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ab2a6cf1-d52a-45f7-988d-5c607f570cbd Target locations of links might be accessible only to IBM employees. |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_KAr1wBhyEe-aC7a28EbkCw Target locations of links might be accessible only to IBM employees. |
|
#libby |
|
The build wrodrig-27692-20240522-1341 |
In this pull request we are working to add the `audit-2.0` feature. This feature is very similar to audit-1.0 feature the main difference is that it doesn't involve rest handler features. More information about this feature can be found here:
OpenLiberty#27475
|
#libby |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
As it is, when the
audit-1.0feature is enabled, it automatically pulls rest-handler dependecies.When this new audit feature is enabled, the rest-handler dependecies will only be added when is enabling features that enable restHandler-1.0 functionalities.
This PR is looking to address #27475