Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fattest.simplicity updates #28112

Merged
merged 3 commits into from
Jun 3, 2024
Merged

fattest.simplicity updates #28112

merged 3 commits into from
Jun 3, 2024

Conversation

jhanders34
Copy link
Member

@jhanders34 jhanders34 commented Apr 9, 2024 •
edited
Loading

  • Synchronize with websphere liberty fattest.simplicity
  • Remove websphere specific config elements from ServerConfiguration
  • Update to make some things extendable in order for it to be extended in websphere liberty specific subclasses
  • Remove all calls to RemoteFile constructor and rely on Machine.getFile() to create a RemoteFile which may be a subclass

Update com.ibm.ws.rest.handler FATs for HttpsRequest changes

  • Changes from using HttpUtils to set HttpsURLConnections to using HttpsRequest methods to set things. HttpsRequest doesn't use HttpsUrlConnection any longer so need to set things up to pass things to the connection / request.
  • Update URLs to encode special characters like brackets that were not encoded. Apache commons httpclient doesn't support brackets not being encoded because it uses URI where HttpsUrlConnection was using URL.

@jhanders34 jhanders34 added this to the 24.8 milestone Apr 9, 2024
@jhanders34 jhanders34 self-assigned this Apr 9, 2024
@LibbyBot
Copy link

LibbyBot commented Apr 9, 2024

The following files contain a string indicating discriminating content:

  • dev/fattest.simplicity/src/com/ibm/websphere/simplicity/config/WebContainerElement.java

@jhanders34
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Apr 9, 2024

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=f54db6c1-e805-424a-9267-bfd28d158786

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Apr 9, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_RUk3wPYQEe6L_suoStyaeQ

Target locations of links might be accessible only to IBM employees.

@jhanders34
Copy link
Member Author

#libby #build

@LibbyBot
Copy link

LibbyBot commented Apr 9, 2024

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8ee56339-cbbf-43f8-98ef-aab8252d9f2d

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Apr 9, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ghVusPaFEe6L_suoStyaeQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Apr 9, 2024

The following files contain a string indicating discriminating content:

  • dev/fattest.simplicity/src/com/ibm/websphere/simplicity/config/WebContainerElement.java

@LibbyBot
Copy link

LibbyBot commented Apr 9, 2024

The build jhanders34-28112-20240408-1935
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_RUk3wPYQEe6L_suoStyaeQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_RUk3wPYQEe6L_suoStyaeQ

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8ee56339-cbbf-43f8-98ef-aab8252d9f2d has errors/failures.

@jhanders34
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=9964e210-3c3d-4969-a53b-9ad5f858f1a0

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-5MIMPbYEe6L_suoStyaeQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=9964e210-3c3d-4969-a53b-9ad5f858f1a0 has errors/failures.

@LibbyBot
Copy link

The build jhanders34-28112-20240409-0937
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ghVusPaFEe6L_suoStyaeQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_ghVusPaFEe6L_suoStyaeQ

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=f54db6c1-e805-424a-9267-bfd28d158786 has errors/failures.

@LibbyBot
Copy link

The build jhanders34-28112-20240409-1933
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-5MIMPbYEe6L_suoStyaeQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_-5MIMPbYEe6L_suoStyaeQ

@jhanders34 jhanders34 force-pushed the branch2 branch 3 times, most recently from 2a331b5 to 82695cf Compare April 29, 2024 22:38
@jhanders34 jhanders34 force-pushed the branch2 branch 3 times, most recently from 60fe368 to ce676d9 Compare May 3, 2024 20:00
@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_y02P0B0oEe-rEslQpyeuMw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4de4d578-330a-4be5-bd61-62277d671109 has errors/failures.

@jhanders34
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=341bd97c-4c15-4d51-a74d-5f90e8bc7d45

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jU2i4B27Ee-rEslQpyeuMw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build jhanders34-28112-20240528-1338
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_y02P0B0oEe-rEslQpyeuMw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_y02P0B0oEe-rEslQpyeuMw

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=341bd97c-4c15-4d51-a74d-5f90e8bc7d45 completed.

@LibbyBot
Copy link

The build jhanders34-28112-20240529-0710
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jU2i4B27Ee-rEslQpyeuMw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_jU2i4B27Ee-rEslQpyeuMw

jhanders34 added 3 commits May 30, 2024 14:14
@jhanders34
fattest.simplicity updates
b3a9971 
- Synchronize with websphere liberty fattest.simplicity
- Remove websphere specific config elements from ServerConfiguration
- Update to make some things extendable in order for it to be extended
in websphere liberty specific subclasses
@jhanders34
Update FATs to use Machine.getFile() instead of newing up RemoteFile
a74cfc8
@jhanders34
Update com.ibm.ws.rest.handler FATs for HttpsRequest changes
1412623 
- Changes from using HttpUtils to set HttpsURLConnections to using
HttpsRequest methods to set things.  HttpsRequest doesn't use
HttpsUrlConnection any longer so need to set things up to pass things to
the connection / request.
- Update URLs to encode special characters like brackets that were not
encoded.  Apache commons httpclient doesn't support brackets not being
encoded because it uses URI where HttpsUrlConnection was using URL.
@jhanders34
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=379d6373-1011-49ab-b85d-750b1ddf7b75

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_VLkKwB69Ee-rEslQpyeuMw

Target locations of links might be accessible only to IBM employees.

@jhanders34 jhanders34 requested review from njr-11 and KyleAure May 30, 2024 22:52
@jhanders34
Copy link
Member Author

@KyleAure I added you on review for overall review of the changes and both you and @njr-11 specifically for commit #3.

KyleAure
KyleAure approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@KyleAure KyleAure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for testcontainer's look good.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=379d6373-1011-49ab-b85d-750b1ddf7b75 has errors/failures.

@LibbyBot
Copy link

The build jhanders34-28112-20240530-1355
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_VLkKwB69Ee-rEslQpyeuMw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_VLkKwB69Ee-rEslQpyeuMw

@LibbyBot
Copy link

The build jhanders34-28112-20240530-2217
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/__X_6UB7IEe-rEslQpyeuMw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=__X_6UB7IEe-rEslQpyeuMw

@jhanders34
Copy link
Member Author

#libby

@LibbyBot
Copy link

LibbyBot commented Jun 3, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 3 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 36 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 71 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

LibbyBot commented Jun 3, 2024

The following files contain a string indicating discriminating content:

  • dev/fattest.simplicity/src/com/ibm/websphere/simplicity/config/WebContainerElement.java

@jhanders34 jhanders34 merged commit ecc377c into OpenLiberty:integration Jun 3, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njr-11 njr-11 Awaiting requested review from njr-11

@KyleAure KyleAure Awaiting requested review from KyleAure

Assignees

@jhanders34 jhanders34

Labels
CLA Signed team:Performance
Projects
None yet
Milestone
[Iteration 24.8] Apr 15 - Apr 26
Development

Successfully merging this pull request may close these issues.
4 participants
@jhanders34 @LibbyBot @njr-11 @KyleAure