WAR class path loader configuration and tests for default and EAR loader behavior #29340

tjwatson · 2024-08-09T16:19:47Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

################################################################################################

tjwatson · 2024-08-09T16:20:09Z

#build

LibbyBot · 2024-08-09T16:20:23Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5cPBkFZiEe-nla_L9rYqvA

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-08-09T16:27:54Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=755a8f70-0e2a-40e7-b587-048e977d7484

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-08-10T00:45:32Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=755a8f70-0e2a-40e7-b587-048e977d7484 completed.

LibbyBot · 2024-08-10T02:29:33Z

The build tjwatson-29340-20240809-1626
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5cPBkFZiEe-nla_L9rYqvA
completed successfully!

tjwatson · 2024-08-13T13:40:02Z

#build

LibbyBot · 2024-08-13T13:40:12Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LuhX0FlxEe-nla_L9rYqvA

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-08-13T14:36:47Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0dee71b2-d5cd-4bab-a214-d90279f38a1c

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-08-13T23:34:45Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0dee71b2-d5cd-4bab-a214-d90279f38a1c has errors/failures.

LibbyBot · 2024-08-14T08:05:28Z

The build tjwatson-29340-20240813-0648
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LuhX0FlxEe-nla_L9rYqvA
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_LuhX0FlxEe-nla_L9rYqvA

tjwatson · 2024-08-14T16:29:31Z

#build

LibbyBot · 2024-08-14T16:29:46Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CQM9AFpSEe-nla_L9rYqvA

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-08-14T17:35:02Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=39df3964-d8fa-4575-94b4-6570d9216cca

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-08-15T00:03:44Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=39df3964-d8fa-4575-94b4-6570d9216cca has errors/failures.

LibbyBot · 2024-08-15T11:12:55Z

The build tjwatson-29340-20240814-0937
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CQM9AFpSEe-nla_L9rYqvA
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_CQM9AFpSEe-nla_L9rYqvA

tjwatson · 2024-08-27T13:17:45Z

#build

LibbyBot · 2024-08-27T13:43:04Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5yivYGRxEe-O2sUHUib4kg

Target locations of links might be accessible only to IBM employees.

tjwatson · 2024-08-27T15:49:33Z

Related Epic #28110

LibbyBot · 2024-08-28T12:11:14Z

The build tjwatson-29340-20240827-0653
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5yivYGRxEe-O2sUHUib4kg
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_5yivYGRxEe-O2sUHUib4kg

tjwatson · 2024-08-30T20:58:10Z

#build

tjwatson · 2024-09-09T16:03:25Z

Aside from one comment left about the commented out repeat, the CDI test changes look good.

Although the test changes assert the same behaviour with the new flag or or off, this is a change to the existing behaviour where the bean visibility strictly follows the classloader visibility.

At present, when the flag is set, beans declared in libraries on the war classpath are only visible to other beans in the war or its libraries, whereas the classes are visible to the whole application.

We may decide to change this before release.

One clarification here. The failures I was seeing before with earLoader was that the Class-Path references from a WAR would loose visibility to the content of the referenced JARs altogether WRT to the CDI bean visibility tests here. That I believe was a real and true bug in my impl for earLoader. What you state is true though. The bean visibility is gated by the Class-Path closure for the WAR. Same for EJB JARs Class-Path closure in the EAR. That is regardless of the use of warLoader or earLoader for the configuration. We may decide to open that gate up to allow bean visibility to all things available on the parent EAR loader regardless of the computed Class-Path closure.

tjwatson · 2024-09-09T16:17:02Z

#build

LibbyBot · 2024-09-09T16:17:16Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fcb315fb-086e-4c8a-a3aa-c83e24dd84fe

Target locations of links might be accessible only to IBM employees.

tjwatson · 2024-09-09T16:21:17Z

#build

LibbyBot · 2024-09-09T16:21:32Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=36206b09-128c-4270-bba5-ff65827d9337

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-09-09T16:22:43Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=36206b09-128c-4270-bba5-ff65827d9337 has errors/failures.

LibbyBot · 2024-09-09T18:47:02Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hMcYkG7TEe-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-09-09T18:52:03Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_OFC0cG7UEe-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

dazavala

Latest three commits LGTM. I know you're waiting on a doc review of the new metatype properties; that all looks logically consistent.

LibbyBot · 2024-09-10T00:56:37Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fcb315fb-086e-4c8a-a3aa-c83e24dd84fe has errors/failures.

LibbyBot · 2024-09-10T13:31:48Z

The build tjwatson-29340-20240909-1155
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hMcYkG7TEe-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_hMcYkG7TEe-0ZL4JeBVc2g

LibbyBot · 2024-09-10T13:43:01Z

The build tjwatson-29340-20240909-1200
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_OFC0cG7UEe-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_OFC0cG7UEe-0ZL4JeBVc2g

tjwatson · 2024-09-10T13:55:14Z

#libby

dmuelle

ID review- some suggestions per IBM style and a question to clarify on the last two descriptions. I think I understand hopw these all fit together but im not sure what we're asking the user to specify to define the attributes

dev/com.ibm.ws.app.manager.war/resources/OSGI-INF/l10n/metatype.properties

Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>

dmuelle

LGTM, thanks

tjwatson · 2024-09-10T20:28:48Z

#libby

LibbyBot · 2024-09-10T22:40:03Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

10 product code files were changed.
Please describe in a separate comment how you tested your changes.
126 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
dev/com.ibm.ws.app.manager.war/resources/OSGI-INF/l10n/metatype.properties

LibbyBot added CLA Signed noproductcode labels Aug 9, 2024

tjwatson force-pushed the earClassPathTest branch from 40eea80 to ee564bf Compare August 12, 2024 13:42

LibbyBot removed the noproductcode label Aug 13, 2024

tjwatson force-pushed the earClassPathTest branch from 0194a0a to 56e658c Compare August 13, 2024 13:39

tjwatson force-pushed the earClassPathTest branch from 56e658c to e9681cb Compare August 14, 2024 16:28

tjwatson force-pushed the earClassPathTest branch from e9681cb to 5649429 Compare August 27, 2024 13:16

tjwatson changed the title ~~Add EAR class loading tests for Class-Path processing~~ Heritage class path configuration and tests for default and heritage behavior Aug 27, 2024

tjwatson force-pushed the earClassPathTest branch from 5649429 to 282d45b Compare August 30, 2024 17:11

tjwatson changed the title ~~Heritage class path configuration and tests for default and heritage behavior~~ WAR class path loader configuration and tests for default and EAR loader behavior Aug 30, 2024

tjwatson added 2 commits September 9, 2024 11:11

Add doc messages for new configuration metatype

bc89ef5

Remove commented out test rule for repeating EE versions

144ced7

tjwatson dismissed stale reviews from Azquelt and dazavala via 144ced7 September 9, 2024 16:16

dazavala previously approved these changes Sep 9, 2024

View reviewed changes

dmuelle requested changes Sep 10, 2024

View reviewed changes

dmuelle added the ID waiting on development label Sep 10, 2024

Apply suggestions from Doc review

6801bdb

Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>

tjwatson dismissed dazavala’s stale review via 6801bdb September 10, 2024 16:52

tjwatson removed the ID waiting on development label Sep 10, 2024

dmuelle approved these changes Sep 10, 2024

View reviewed changes

dazavala self-requested a review September 10, 2024 20:15

dazavala approved these changes Sep 10, 2024

View reviewed changes

posmith added the L2 ReviewNotRequired label Sep 11, 2024

ramkumar-k-9286 added the ID review not needed label Sep 11, 2024

tjwatson merged commit 16635fd into OpenLiberty:integration Sep 11, 2024
2 checks passed

WAR class path loader configuration and tests for default and EAR loader behavior #29340

WAR class path loader configuration and tests for default and EAR loader behavior #29340

Conversation

tjwatson commented Aug 9, 2024 • edited Loading

tjwatson commented Aug 9, 2024

LibbyBot commented Aug 9, 2024

LibbyBot commented Aug 9, 2024

LibbyBot commented Aug 10, 2024

LibbyBot commented Aug 10, 2024

tjwatson commented Aug 13, 2024

LibbyBot commented Aug 13, 2024

LibbyBot commented Aug 13, 2024

LibbyBot commented Aug 13, 2024

LibbyBot commented Aug 14, 2024

tjwatson commented Aug 14, 2024

LibbyBot commented Aug 14, 2024

LibbyBot commented Aug 14, 2024

LibbyBot commented Aug 15, 2024

LibbyBot commented Aug 15, 2024

tjwatson commented Aug 27, 2024

LibbyBot commented Aug 27, 2024

tjwatson commented Aug 27, 2024

LibbyBot commented Aug 28, 2024

tjwatson commented Aug 30, 2024

tjwatson commented Sep 9, 2024

tjwatson commented Sep 9, 2024

LibbyBot commented Sep 9, 2024

tjwatson commented Sep 9, 2024

LibbyBot commented Sep 9, 2024

LibbyBot commented Sep 9, 2024

LibbyBot commented Sep 9, 2024

LibbyBot commented Sep 9, 2024

dazavala left a comment

Choose a reason for hiding this comment

LibbyBot commented Sep 10, 2024

LibbyBot commented Sep 10, 2024

LibbyBot commented Sep 10, 2024

tjwatson commented Sep 10, 2024

dmuelle left a comment

Choose a reason for hiding this comment

dmuelle left a comment

Choose a reason for hiding this comment

tjwatson commented Sep 10, 2024

LibbyBot commented Sep 10, 2024

Code analysis and actions

tjwatson commented Aug 9, 2024 •

edited

Loading