Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wait infinitely for client run or server stop to complete (attempt #2) #29654

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Don't wait infinitely for client run or server stop to complete (attempt #2) #29654

merged 1 commit into from
Sep 24, 2024

Conversation

jhanders34
Copy link
Member

  • Update LocalProvider to handle a timeout value
  • Update LibertyClient to pass in a timeout of 300 seconds for a client to finish so it doesn't hang
  • Update LibertyServer to pass in a timeout of 300 seconds for a server stop call to finish so it doesn't hang

Fixes #29642
Re-introduces the changes from #29540 with additional changes to fix up some stuff when running on iSeries

@jhanders34 jhanders34 requested a review from gjwatts September 14, 2024 12:27
@jhanders34 jhanders34 self-assigned this Sep 14, 2024
@jhanders34
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=509dc5a4-c8c3-47dc-bb42-f1a2b377290b

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_bbC1oHKMEe-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

@jhanders34
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fadf1570-4435-4595-bd85-ab44dcb2abae

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_klly0HL-Ee-ZBdXWdK7Miw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=509dc5a4-c8c3-47dc-bb42-f1a2b377290b has errors/failures.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fadf1570-4435-4595-bd85-ab44dcb2abae has errors/failures.

@LibbyBot
Copy link

The build jhanders34-29654-20240914-1717
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_bbC1oHKMEe-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_bbC1oHKMEe-0ZL4JeBVc2g

@LibbyBot
Copy link

The build jhanders34-29654-20240914-1913
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_klly0HL-Ee-ZBdXWdK7Miw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_klly0HL-Ee-ZBdXWdK7Miw

@jhanders34
Don't wait infinitely for client run or server stop to complete
b8d6900 
- Update LocalProvider to handle a timeout value
- Update LibertyClient to pass in a timeout of 300 seconds for a client
to finish so it doesn't hang
- Update LibertyServer to pass in a timeout of 300 seconds for a server
stop call to finish so it doesn't hang
@jhanders34
Copy link
Member Author

#libby #build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1cc2f0de-8fc8-4429-b777-c9d9136cd764

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_sFQWUHSTEe-ZBdXWdK7Miw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • Please describe in a separate comment how you tested your changes.

  • 5 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1cc2f0de-8fc8-4429-b777-c9d9136cd764 has errors/failures.

@LibbyBot
Copy link

The build jhanders34-29654-20240916-1933
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_sFQWUHSTEe-ZBdXWdK7Miw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_sFQWUHSTEe-ZBdXWdK7Miw

@jhanders34 jhanders34 merged commit 920495c into OpenLiberty:integration Sep 24, 2024
2 of 3 checks passed
@jhanders34 jhanders34 mentioned this pull request Oct 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjwatts gjwatts gjwatts approved these changes

Assignees

@jhanders34 jhanders34

Labels
CLA Signed noproductcode team:Performance
Projects
None yet
Milestone
[Iteration 24.19] Sep 16 - Sep 27
Development

Successfully merging this pull request may close these issues.

Re-introduce change reverted from 29540
3 participants
@jhanders34 @LibbyBot @gjwatts