-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate OpenLiberty #29459 #30180
base: integration
Are you sure you want to change the base?
Recreate OpenLiberty #29459 #30180
Conversation
#build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fb5d0d5e-1e30-4cc1-84c7-800b4c14651b Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_NfUPwKKeEe-kGLEyqlUFUA The build will run your changed FAT bucket(s) 10 times. Target locations of links might be accessible only to IBM employees. |
...a_32_fat/test-applications/jakartadata/src/io/openliberty/jpa/data/tests/models/Segment.java
Outdated
Show resolved
Hide resolved
|
||
try { | ||
// Persist the segment using EntityManager | ||
em.persist(segment); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This persist operation will not attempt to persist the entity until tx.commit()
is called.
Therefore, you are not testing the same behavior as the original issue.
(see next comment for a suggestion on how to do this correctly)
// Begin the transaction | ||
tx.begin(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Begin the transaction | |
tx.begin(); | |
try { | |
tx.begin(); | |
em.persist(segment); | |
tx.commit(); | |
} catch (Exception e) { | |
tx.rollback(); | |
// Expect original failure here if eclipselink created the table as: | |
// CREATE TABLE Segment (ID BIGINT NOT NULL, X INTEGER, Y INTEGER, PRIMARY KEY (ID)) | |
// instead of | |
// CREATE TABLE WLPSegment (ID BIGINT NOT NULL, | |
// [unique_column_id_a]_X INTEGER, [unique_column_id_a]_Y INTEGER, | |
// [unique_column_id_b]_X INTEGER, [unique_column_id_b]_Y INTEGER, | |
// PRIMARY KEY (ID)) | |
throw e; | |
} |
...plications/jakartadata/src/io/openliberty/jpa/data/tests/web/JakartaDataRecreateServlet.java
Outdated
Show resolved
Hide resolved
...plications/jakartadata/src/io/openliberty/jpa/data/tests/web/JakartaDataRecreateServlet.java
Outdated
Show resolved
Hide resolved
a715f28
to
a070552
Compare
#build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a60ca7b2-7879-48b6-9fd8-f28d37819d96 Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LNVOoaaGEe-WbLf72iZSEQ The build will run your changed FAT bucket(s) 10 times. Target locations of links might be accessible only to IBM employees. |
Recreate OpenLiberty #29459