Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate OpenLiberty #29459 #30180

Open
wants to merge 7 commits into
base: integration
Choose a base branch
from

Conversation

anija-anil
Copy link
Contributor

Recreate OpenLiberty #29459

@anija-anil
Copy link
Contributor Author

#build

@contbld
Copy link
Collaborator

contbld commented Nov 14, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fb5d0d5e-1e30-4cc1-84c7-800b4c14651b

Target locations of links might be accessible only to IBM employees.

@contbld
Copy link
Collaborator

contbld commented Nov 14, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 FAT files were changed, added, or removed.
  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • Please describe in a separate comment how you tested your changes.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_NfUPwKKeEe-kGLEyqlUFUA

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@contbld
Copy link
Collaborator

contbld commented Nov 15, 2024


try {
// Persist the segment using EntityManager
em.persist(segment);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This persist operation will not attempt to persist the entity until tx.commit() is called.
Therefore, you are not testing the same behavior as the original issue.
(see next comment for a suggestion on how to do this correctly)

Comment on lines +181 to +182
// Begin the transaction
tx.begin();
Copy link
Member

@KyleAure KyleAure Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Begin the transaction
tx.begin();
try {
tx.begin();
em.persist(segment);
tx.commit();
} catch (Exception e) {
tx.rollback();
// Expect original failure here if eclipselink created the table as:
// CREATE TABLE Segment (ID BIGINT NOT NULL, X INTEGER, Y INTEGER, PRIMARY KEY (ID))
// instead of
// CREATE TABLE WLPSegment (ID BIGINT NOT NULL,
// [unique_column_id_a]_X INTEGER, [unique_column_id_a]_Y INTEGER,
// [unique_column_id_b]_X INTEGER, [unique_column_id_b]_Y INTEGER,
// PRIMARY KEY (ID))
throw e;
}

@anija-anil
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a60ca7b2-7879-48b6-9fd8-f28d37819d96

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 FAT files were changed, added, or removed.
  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LNVOoaaGEe-WbLf72iZSEQ

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants