UpgradeHandler may not notify the application to read the initial data that sent along with the upgrade request. #30328

pmd1nh · 2024-12-03T17:28:23Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

################################################################################################

pmd1nh · 2024-12-03T18:01:20Z

#build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
#spawn.fullfat.buckets=io.openliberty.webcontainer.servlet.6.1.internal_fat,io.openliberty.webcontainer.servlet.6.0.internal_fat,com.ibm.ws.webcontainer.servlet.6.1_fat_toleration.lWAS,com.ibm.ws.webcontainer.servlet.6.0_fat_toleration.lWAS,com.ibm.ws.webcontainer_fat,com.ibm.ws.webcontainer.servlet.3.1_fat,com.ibm.ws.webcontainer.servlet.3.1_fat.2,com.ibm.ws.webcontainer.servlet.4.0_fat,com.ibm.ws.webcontainer_fat_part2,com.ibm.ws.webcontainer_fat_servlet31toleration,com.ibm.ws.webcontainer_fat_servlet31toleration_part2,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0_part2,com.ibm.ws.webcontainer_fat_lWAS,com.ibm.ws.webcontainer_fat_servlet31_webcontainerlWAS,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0.lWAS,com.ibm.ws.transport.http_test

LibbyBot · 2024-12-03T22:45:29Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-12-03T23:39:28Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_dB-V0bHHEe-Q24Sd2QdBoQ

Target locations of links might be accessible only to IBM employees.

pmd1nh · 2024-12-04T19:28:01Z

#build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)

#spawn.fullfat.buckets=io.openliberty.webcontainer.servlet.6.1.internal_fat,io.openliberty.webcontainer.servlet.6.0.internal_fat,com.ibm.ws.webcontainer.servlet.6.1_fat_toleration.lWAS,com.ibm.ws.webcontainer.servlet.6.0_fat_toleration.lWAS,com.ibm.ws.webcontainer_fat,com.ibm.ws.webcontainer.servlet.3.1_fat,com.ibm.ws.webcontainer.servlet.3.1_fat.2,com.ibm.ws.webcontainer.servlet.4.0_fat,com.ibm.ws.webcontainer_fat_part2,com.ibm.ws.webcontainer_fat_servlet31toleration,com.ibm.ws.webcontainer_fat_servlet31toleration_part2,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0_part2,com.ibm.ws.webcontainer_fat_lWAS,com.ibm.ws.webcontainer_fat_servlet31_webcontainerlWAS,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0.lWAS,com.ibm.ws.transport.http_test

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-04T19:35:37Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-12-05T05:51:27Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lcwZ0LLEEe-Q24Sd2QdBoQ

Target locations of links might be accessible only to IBM employees.

...bm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java

isaacrivriv

Nice work on this, changes look good to me

pnicolucci · 2024-12-13T18:42:50Z

@pmd1nh the parent issue needs to be updated to use the release bug template. Thanks!

...bm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java

....webcontainer.servlet.3.1/src/com/ibm/ws/webcontainer31/util/UpgradeInputByteBufferUtil.java

pmd1nh · 2024-12-16T17:53:41Z

#build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
#spawn.fullfat.buckets=io.openliberty.webcontainer.servlet.6.1.internal_fat,io.openliberty.webcontainer.servlet.6.0.internal_fat,com.ibm.ws.webcontainer.servlet.6.1_fat_toleration.lWAS,com.ibm.ws.webcontainer.servlet.6.0_fat_toleration.lWAS,com.ibm.ws.webcontainer_fat,com.ibm.ws.webcontainer.servlet.3.1_fat,com.ibm.ws.webcontainer.servlet.3.1_fat.2,com.ibm.ws.webcontainer.servlet.4.0_fat,com.ibm.ws.webcontainer_fat_part2,com.ibm.ws.webcontainer_fat_servlet31toleration,com.ibm.ws.webcontainer_fat_servlet31toleration_part2,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0_part2,com.ibm.ws.webcontainer_fat_lWAS,com.ibm.ws.webcontainer_fat_servlet31_webcontainerlWAS,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0.lWAS,com.ibm.ws.transport.http_test

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-16T18:00:34Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-12-17T00:52:32Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_0Oxr0rwIEe-V7IPhyP5jiw

Target locations of links might be accessible only to IBM employees.

pmd1nh · 2024-12-19T18:32:20Z

#build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
#spawn.fullfat.buckets=com.ibm.ws.webcontainer.servlet.3.1_fat,com.ibm.ws.webcontainer.servlet.3.1_fat.2,com.ibm.ws.webcontainer.servlet.4.0_fat,com.ibm.ws.webcontainer_fat_part2,com.ibm.ws.webcontainer_fat_servlet31toleration,com.ibm.ws.webcontainer_fat_servlet31toleration_part2,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0_part2,com.ibm.ws.webcontainer_fat_lWAS,com.ibm.ws.webcontainer_fat_servlet31_webcontainerlWAS,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0.lWAS,com.ibm.ws.transport.http_test

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-19T18:43:14Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-12-19T20:33:30Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_H-MCEb5AEe-V7IPhyP5jiw

Target locations of links might be accessible only to IBM employees.

pmd1nh · 2024-12-20T18:53:03Z

All WC full tests passed.
(view Open Liberty Personal Build - ✅ completed successfully!)
There are other buckets failure due to Socket timeout...just rerun build

#build

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-20T19:00:38Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-12-20T22:16:28Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_rMLfIL8XEe-V7IPhyP5jiw

Target locations of links might be accessible only to IBM employees.

pmd1nh self-assigned this Dec 3, 2024

pmd1nh added team:Sirius in:Web Components labels Dec 3, 2024

LibbyBot added the CLA Signed label Dec 3, 2024

pmd1nh force-pushed the UpgradeHandler_May_Miss_Initial_Data branch from f96ee7b to e3d7006 Compare December 4, 2024 19:21

UpgradeHandler may not read the initial data

b9d4c8e

pmd1nh force-pushed the UpgradeHandler_May_Miss_Initial_Data branch from e3d7006 to b9d4c8e Compare December 4, 2024 19:54

pmd1nh requested review from isaacrivriv and pnicolucci December 5, 2024 14:43

pmd1nh commented Dec 5, 2024

View reviewed changes

...bm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java Show resolved Hide resolved

Update log

e53b50f

isaacrivriv previously approved these changes Dec 13, 2024

View reviewed changes

Update logs

6764470

pmd1nh dismissed isaacrivriv’s stale review via 6764470 December 13, 2024 17:53

pmd1nh changed the title ~~UpgradeHandler may not read the initial data~~ UpgradeHandler may not notify the application to read the initial data that sent along with the upgrade request. Dec 13, 2024

pnicolucci reviewed Dec 13, 2024

View reviewed changes

...bm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java Outdated Show resolved Hide resolved

pnicolucci reviewed Dec 13, 2024

View reviewed changes

....webcontainer.servlet.3.1/src/com/ibm/ws/webcontainer31/util/UpgradeInputByteBufferUtil.java Outdated Show resolved Hide resolved

pnicolucci reviewed Dec 13, 2024

View reviewed changes

....webcontainer.servlet.3.1/src/com/ibm/ws/webcontainer31/util/UpgradeInputByteBufferUtil.java Outdated Show resolved Hide resolved

Address message's review comments

469cdd4

pmd1nh requested a review from pnicolucci December 16, 2024 17:54

pnicolucci approved these changes Dec 19, 2024

View reviewed changes

pmd1nh merged commit 1b3ee57 into OpenLiberty:integration Dec 22, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UpgradeHandler may not notify the application to read the initial data that sent along with the upgrade request. #30328

UpgradeHandler may not notify the application to read the initial data that sent along with the upgrade request. #30328

pmd1nh commented Dec 3, 2024 •

edited

Loading

pmd1nh commented Dec 3, 2024 •

edited by LibbyBot

Loading

LibbyBot commented Dec 3, 2024

LibbyBot commented Dec 3, 2024

pmd1nh commented Dec 4, 2024 •

edited by LibbyBot

Loading

LibbyBot commented Dec 4, 2024

LibbyBot commented Dec 5, 2024

isaacrivriv left a comment

pnicolucci commented Dec 13, 2024

pmd1nh commented Dec 16, 2024 •

edited by LibbyBot

Loading

LibbyBot commented Dec 16, 2024

LibbyBot commented Dec 17, 2024

pmd1nh commented Dec 19, 2024 •

edited by LibbyBot

Loading

LibbyBot commented Dec 19, 2024

LibbyBot commented Dec 19, 2024

pmd1nh commented Dec 20, 2024 •

edited by LibbyBot

Loading

LibbyBot commented Dec 20, 2024

LibbyBot commented Dec 20, 2024

UpgradeHandler may not notify the application to read the initial data that sent along with the upgrade request. #30328

UpgradeHandler may not notify the application to read the initial data that sent along with the upgrade request. #30328

Conversation

pmd1nh commented Dec 3, 2024 • edited Loading

pmd1nh commented Dec 3, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 3, 2024

Code analysis and actions

LibbyBot commented Dec 3, 2024

pmd1nh commented Dec 4, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 4, 2024

Code analysis and actions

LibbyBot commented Dec 5, 2024

isaacrivriv left a comment

Choose a reason for hiding this comment

pnicolucci commented Dec 13, 2024

pmd1nh commented Dec 16, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 16, 2024

Code analysis and actions

LibbyBot commented Dec 17, 2024

pmd1nh commented Dec 19, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 19, 2024

Code analysis and actions

LibbyBot commented Dec 19, 2024

pmd1nh commented Dec 20, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 20, 2024

Code analysis and actions

LibbyBot commented Dec 20, 2024

pmd1nh commented Dec 3, 2024 •

edited

Loading

pmd1nh commented Dec 3, 2024 •

edited by LibbyBot

Loading

pmd1nh commented Dec 4, 2024 •

edited by LibbyBot

Loading

pmd1nh commented Dec 16, 2024 •

edited by LibbyBot

Loading

pmd1nh commented Dec 19, 2024 •

edited by LibbyBot

Loading

pmd1nh commented Dec 20, 2024 •

edited by LibbyBot

Loading