Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracespec in logging fat #30448

Merged

Conversation

isaacrivriv
Copy link
Member

Updating logging FAT trace specification for future Netty changes. Tracing will change from the originating class with these changes but will be enabled through the same trace group. After some discussion with serviceability, since the trace group is the same and the must gather information uses these trace groups, these changes are valid since only for internal support will these specific classes be used.

@isaacrivriv isaacrivriv self-assigned this Dec 20, 2024
@isaacrivriv
Copy link
Member Author

isaacrivriv commented Dec 20, 2024

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@mrsaldana mrsaldana self-requested a review December 20, 2024 15:30
Copy link
Member

@mrsaldana mrsaldana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks Isaac!

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_xsCaIb75Ee-V7IPhyP5jiw

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@isaacrivriv isaacrivriv merged commit 5ec3176 into OpenLiberty:integration Dec 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants