Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new edtion and product id for Open Liberty #3258

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

idlewis
Copy link
Member

@idlewis idlewis commented Apr 24, 2018

This is a re-do of pull request #3215, but with the product id correctly capitalized as per conversation in #3246

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@idlewis
Copy link
Member Author

idlewis commented Apr 24, 2018

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_vYd3kEezEeiBcaHL18STjw

Target locations of links might be accessible only to IBM employees.

@idlewis idlewis force-pushed the appliesTo2 branch 2 times, most recently from dfe3351 to d1c4c46 Compare April 24, 2018 18:21
@idlewis
Copy link
Member Author

idlewis commented Apr 24, 2018

first build failed as the tests hadn't been updated properly
#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5RSZMEfnEeiBcaHL18STjw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build idlewis-3258-20180424-1856
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5RSZMEfnEeiBcaHL18STjw
completed and has errors or failures.

AppliesToProcessor needs to recognize OPEN as a valid edition
and also have an appropriate mapping to a human readable edition.
OPEN features can be installed on any edition apart from CORE

Also do a bit of refactoring to put the parsing logic into a
common method, and make a couple of methods private, as they
clearly should have been
@idlewis
Copy link
Member Author

idlewis commented Apr 25, 2018

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_4zOckEiJEeiBcaHL18STjw

Target locations of links might be accessible only to IBM employees.

EARLY_ACCESS("EARLY_ACCESS");
EARLY_ACCESS("EARLY_ACCESS"),
Open("Open"),
Open_Web("Open_Web");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going from upper case to camel case (ish) is the only change here from the previous attempt at this pull request

@LibbyBot
Copy link

The build idlewis-3258-20180425-1417
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_4zOckEiJEeiBcaHL18STjw
completed and has errors or failures.

@idlewis
Copy link
Member Author

idlewis commented Apr 26, 2018

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jMayIEkLEeiBcaHL18STjw

Target locations of links might be accessible only to IBM employees.

@idlewis
Copy link
Member Author

idlewis commented Apr 26, 2018

idlewis-3258-20180425-1417 build passed all tests, but there were javacores in the BVT, can't work out why, and there shouldn't be anything in this pull request which should cause it.
The next build has got past the BVT and is green, so I think it is safe to deliver

@idlewis idlewis merged commit 2d261da into OpenLiberty:integration Apr 26, 2018
@LibbyBot
Copy link

The build idlewis-3258-20180426-0546
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jMayIEkLEeiBcaHL18STjw
completed successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants