Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opentracing mock tracker to FAT project; attempt #2 #613

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Move opentracing mock tracker to FAT project; attempt #2 #613

merged 3 commits into from
Oct 30, 2017

Conversation

kgibm
Copy link
Member

@kgibm kgibm commented Oct 20, 2017

Trying to fix #521 while Steve's out

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 7 infrastructure code files were changed.

  • 10 FAT files were changed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.websphere.appserver.opentracingMock-0.30/resources/l10n/com.ibm.websphere.appserver.opentracingMock-0.30.properties

@sishida
Copy link

sishida commented Oct 20, 2017

Greetings! ID writer here! If this issue requires ID review, could you please add the "ID Required" label? If it does not need ID review, could you please add the "ID review not needed" label? Thanks a bunch!

@kgibm
Copy link
Member Author

kgibm commented Oct 20, 2017

@sishida The only ID-related change is that an NLS file was removed, so I'll add "ID review not needed."

@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@OpenLiberty OpenLiberty deleted a comment from LibbyBot Oct 26, 2017
@kgibm
Copy link
Member Author

kgibm commented Oct 26, 2017

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_W0MR4LpYEeeqpdQxFPkl8Q

You changed feature files so I requested a "Liberty IM Offering Build - EBC" build for you:
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_W6OocLpYEeeqpdQxFPkl8Q

Target locations of links might be accessible only to IBM employees.

@kgibm
Copy link
Member Author

kgibm commented Oct 26, 2017

Deleted lots of old failed builds. Rebasing on integration and trying a new build...

@kgibm
Copy link
Member Author

kgibm commented Oct 26, 2017

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_uaMhwLp3EeeqpdQxFPkl8Q

You changed feature files so I requested a "Liberty IM Offering Build - EBC" build for you:
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ufyzdrp3EeeqpdQxFPkl8Q

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build kgibm-613-20171026-1910
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ufyzdrp3EeeqpdQxFPkl8Q
completed and has errors or failures.

@kgibm kgibm requested a review from aguibert October 30, 2017 15:18
@kgibm kgibm changed the title 247182 buildbreak attempt #2 Move opentracing mock tracker to FAT project; attempt #2 Oct 30, 2017
@kgibm kgibm merged commit 134bfb8 into OpenLiberty:integration Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants