Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mininum jdkSourceLevel of 1.7 for JDK 12+ #7202

Merged

Conversation

aguibert
Copy link
Contributor

In JDK 12, the minimum supported source target level is JDK 1.7. Normally, the JSP Engine defaults to the lowest (JDK 1.3), so we need to default to JDK 1.7 on JDK 12+.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 11 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@aguibert
Copy link
Contributor Author

#build #spawnfullfat com.ibm.ws.jsp_fat_lWAS

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_MZFmIFvtEem8NdNdaSGUMw

Target locations of links might be accessible only to IBM employees.

@aguibert
Copy link
Contributor Author

@aguibert
Copy link
Contributor Author

#build #spawn.fullfat.buckets=com.ibm.ws.jsp_fat,com.ibm.ws.jsp_fat_jsp.2.3.toleration,com.ibm.ws.jsp_fat_lWAS

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_P40kgFx-Eem8NdNdaSGUMw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build aguibert-7202-20190411-1831
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_P40kgFx-Eem8NdNdaSGUMw
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_P40kgFx-Eem8NdNdaSGUMw

@aguibert
Copy link
Contributor Author

the java 11 and java 12 builds are good. Will deliver once code review is complete

@epj
Copy link
Contributor

epj commented Apr 12, 2019

Any reason not to default to 1.7 in all cases, not just for Java 12? That's what's proposed in issue #7181.

Copy link
Contributor

@epj epj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change as such just for Java 12 looks good. We can debate if jskSourceLevel should default to 17 for all cases.

@aguibert aguibert merged commit 3f3d9cd into OpenLiberty:integration Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants