Hostname verification support on ssl configuration #7469

acdemyers · 2019-05-09T15:15:03Z

No description provided.

LibbyBot · 2019-05-09T15:15:08Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

5 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
dev/com.ibm.ws.ssl/resources/OSGI-INF/l10n/metatype.properties

acdemyers · 2019-05-09T15:15:26Z

#build

LibbyBot · 2019-05-09T15:15:33Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_6D_EYHJkEemMFeblcfcdEQ

Target locations of links might be accessible only to IBM employees.

Charlotte-Holt

Hi @acdemyers - I've made a few suggestions. Please review them and let me know if you have any questions. Once we agree and the updates are made, I'll add the ID reviewed label. Thanks!

Charlotte-Holt · 2019-05-09T16:00:06Z

dev/com.ibm.ws.ssl/resources/OSGI-INF/l10n/metatype.properties

@@ -47,6 +47,8 @@ repertiore.HIGH=Cipher suites 3DES and 128 bit and higher
 repertiore.MEDIUM=Cipher suites DES and 40 bit
 repertiore.LOW=Cipher suites without encryption
 repertiore.CUSTOM=Custom list of cipher suites
+repertoire.verifyHostname=Perform host name verification for outbound SSL connections using a specific SSL configuration
+repertoire.verifyHostname.desc=Specifies whether host name verification is enabled for outbound connection on using a specific SSL configuration is enabled.  If set to true, all outbound SSL connection using the specified SSL configuration will undergo verification of the target server host name against that server's certificate.  The attribute is false by default.


Change
"Specifies whether host name verification is enabled for outbound connection on using a specific SSL configuration is enabled. If set to true, all outbound SSL connection using the specified SSL configuration will undergo verification of the target server host name against that server's certificate. The attribute is false by default."
to
"The verifyHostname attribute specifies whether host name verification for outbound connections using a specific SSL configuration is enabled. If set to true, then all outbound SSL connections that use the specified SSL configuration undergo verification of the target server host name against that server's certificate. The attribute is set to false by default."

@Charlotte-Holt I've update the metetype.properties file with your suggested changes. Thank you for you comments.

Charlotte-Holt · 2019-05-09T16:02:45Z

dev/com.ibm.ws.ssl/resources/OSGI-INF/l10n/metatype.properties

@@ -47,6 +47,8 @@ repertiore.HIGH=Cipher suites 3DES and 128 bit and higher
 repertiore.MEDIUM=Cipher suites DES and 40 bit
 repertiore.LOW=Cipher suites without encryption
 repertiore.CUSTOM=Custom list of cipher suites
+repertoire.verifyHostname=Perform host name verification for outbound SSL connections using a specific SSL configuration


Change
"Perform host name verification for outbound SSL connections using a specific SSL configuration"
to
"The verifyHostname attribute performs host name verification for outbound SSL connections using a specific SSL configuration."

@Charlotte-Holt I've update the metetype.properties file with your suggested changes. Thank you for you comments.

@acdemyers Label added. Thank you!

LibbyBot · 2019-05-09T19:41:13Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_6D_EYHJkEemMFeblcfcdEQ/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_6D_EYHJkEemMFeblcfcdEQ.

LibbyBot · 2019-05-10T07:32:55Z

The build acdemyers-7469-20190509-1600
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_6D_EYHJkEemMFeblcfcdEQ
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_6D_EYHJkEemMFeblcfcdEQ

andrea-pichler · 2019-05-10T08:21:50Z

No message review from L2 required.

acdemyers · 2019-05-10T14:35:41Z

#build

LibbyBot · 2019-05-10T14:35:53Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_h_ZC4HMoEemMFeblcfcdEQ

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-10T18:23:19Z

The build acdemyers-7469-20190510-1555
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_h_ZC4HMoEemMFeblcfcdEQ
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_h_ZC4HMoEemMFeblcfcdEQ

LibbyBot · 2019-05-10T19:38:21Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_h_ZC4HMoEemMFeblcfcdEQ/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_h_ZC4HMoEemMFeblcfcdEQ.

acdemyers · 2019-05-13T01:28:18Z

#build

LibbyBot · 2019-05-13T01:28:22Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_A0J8kHUWEemWNMQzD7Qc1Q

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-13T06:58:11Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_A0J8kHUWEemWNMQzD7Qc1Q/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_A0J8kHUWEemWNMQzD7Qc1Q.

LibbyBot · 2019-05-13T07:38:44Z

The build acdemyers-7469-20190513-0518
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_A0J8kHUWEemWNMQzD7Qc1Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_A0J8kHUWEemWNMQzD7Qc1Q

acdemyers · 2019-05-13T21:00:32Z

#build

LibbyBot · 2019-05-13T21:00:36Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_xj99gHW5EemWNMQzD7Qc1Q

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-13T22:22:46Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_xj99gHW5EemWNMQzD7Qc1Q/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_xj99gHW5EemWNMQzD7Qc1Q.

acdemyers · 2019-05-13T22:30:13Z

#build

LibbyBot · 2019-05-13T22:30:17Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_TPLdcHXGEemWNMQzD7Qc1Q

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-14T00:26:32Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_TPLdcHXGEemWNMQzD7Qc1Q/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_TPLdcHXGEemWNMQzD7Qc1Q.

LibbyBot · 2019-05-14T01:09:28Z

The build acdemyers-7469-20190513-2239
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_TPLdcHXGEemWNMQzD7Qc1Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_TPLdcHXGEemWNMQzD7Qc1Q

LibbyBot · 2019-05-15T16:42:39Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2019-05-15T16:42:40Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ElBLQHcoEemWNMQzD7Qc1Q

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-15T18:56:08Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_ElBLQHcoEemWNMQzD7Qc1Q/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_ElBLQHcoEemWNMQzD7Qc1Q.

LibbyBot · 2019-05-15T20:58:54Z

The build acdemyers-7469-20190515-1129
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CoRrMHb7EemWNMQzD7Qc1Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_CoRrMHb7EemWNMQzD7Qc1Q

acdemyers · 2019-05-15T23:48:56Z

#build

LibbyBot · 2019-05-15T23:49:02Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2019-05-15T23:49:03Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_oukKgHdjEemWNcQzD7Qc1Q

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-16T01:28:33Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_oukKgHdjEemWNcQzD7Qc1Q/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_oukKgHdjEemWNcQzD7Qc1Q.

LibbyBot · 2019-05-16T03:15:17Z

The build acdemyers-7469-20190515-1653
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ElBLQHcoEemWNMQzD7Qc1Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_ElBLQHcoEemWNMQzD7Qc1Q

LibbyBot · 2019-05-16T08:48:42Z

The build acdemyers-7469-20190515-2357
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_oukKgHdjEemWNcQzD7Qc1Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_oukKgHdjEemWNcQzD7Qc1Q

acdemyers · 2019-05-16T13:25:55Z

#build

LibbyBot · 2019-05-16T13:26:03Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2019-05-16T13:26:05Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_xfwMgXfVEemWNcQzD7Qc1Q

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-16T15:19:37Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_xfwMgXfVEemWNcQzD7Qc1Q/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_xfwMgXfVEemWNcQzD7Qc1Q.

acdemyers · 2019-05-16T15:47:13Z

#build

LibbyBot · 2019-05-16T15:47:23Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2019-05-16T15:47:25Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hEIXgHfpEemWNcQzD7Qc1Q

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2019-05-16T17:28:49Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_hEIXgHfpEemWNcQzD7Qc1Q/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_hEIXgHfpEemWNcQzD7Qc1Q.

LibbyBot · 2019-05-17T01:26:40Z

The build acdemyers-7469-20190516-1555
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hEIXgHfpEemWNcQzD7Qc1Q
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_hEIXgHfpEemWNcQzD7Qc1Q

LibbyBot added the CLA Signed label May 9, 2019

Charlotte-Holt reviewed May 9, 2019

View reviewed changes

andrea-pichler added the L2 ReviewNotRequired label May 10, 2019

acdemyers force-pushed the 7456-verifyHostname branch from 6cde703 to 203d957 Compare May 10, 2019 14:32

Charlotte-Holt added the ID reviewed label May 10, 2019

acdemyers force-pushed the 7456-verifyHostname branch from 203d957 to 064aadf Compare May 13, 2019 01:28

acdemyers force-pushed the 7456-verifyHostname branch from 064aadf to 0972878 Compare May 13, 2019 20:55

acdemyers force-pushed the 7456-verifyHostname branch 2 times, most recently from 674048c to aea0491 Compare May 14, 2019 16:10

acdemyers force-pushed the 7456-verifyHostname branch from 853f3ab to 311e0b6 Compare May 15, 2019 23:44

acdemyers requested a review from emilytee May 16, 2019 12:49

acdemyers force-pushed the 7456-verifyHostname branch from 311e0b6 to 5139586 Compare May 16, 2019 13:25

Hostname verification support on ssl configuration

251a11e

acdemyers force-pushed the 7456-verifyHostname branch from 5139586 to 251a11e Compare May 16, 2019 15:46

acdemyers self-assigned this May 16, 2019

emilytee approved these changes May 17, 2019

View reviewed changes

acdemyers merged commit 5f2ef3e into OpenLiberty:integration May 17, 2019

acdemyers deleted the 7456-verifyHostname branch June 11, 2019 20:30

acdemyers mentioned this pull request Jun 19, 2019

Allow hostname verification to be set on SSL configuration #7436

Closed

ayoho mentioned this pull request Jul 1, 2019

NullPointerException at SSLConfigManager.getCipherList #8071

Closed

Hostname verification support on ssl configuration #7469

Hostname verification support on ssl configuration #7469

Conversation

acdemyers commented May 9, 2019

LibbyBot commented May 9, 2019

Code analysis and actions

acdemyers commented May 9, 2019

LibbyBot commented May 9, 2019

Charlotte-Holt left a comment

Choose a reason for hiding this comment

Charlotte-Holt May 9, 2019

Choose a reason for hiding this comment

acdemyers May 10, 2019

Choose a reason for hiding this comment

Charlotte-Holt May 9, 2019

Choose a reason for hiding this comment

acdemyers May 10, 2019

Choose a reason for hiding this comment

Charlotte-Holt May 10, 2019

Choose a reason for hiding this comment

LibbyBot commented May 9, 2019

LibbyBot commented May 10, 2019

andrea-pichler commented May 10, 2019

acdemyers commented May 10, 2019

LibbyBot commented May 10, 2019

LibbyBot commented May 10, 2019

LibbyBot commented May 10, 2019

acdemyers commented May 13, 2019

LibbyBot commented May 13, 2019

LibbyBot commented May 13, 2019

LibbyBot commented May 13, 2019

acdemyers commented May 13, 2019

LibbyBot commented May 13, 2019

LibbyBot commented May 13, 2019

acdemyers commented May 13, 2019

LibbyBot commented May 13, 2019

LibbyBot commented May 14, 2019

LibbyBot commented May 14, 2019

LibbyBot commented May 15, 2019

LibbyBot commented May 15, 2019

LibbyBot commented May 15, 2019

LibbyBot commented May 15, 2019

acdemyers commented May 15, 2019

LibbyBot commented May 15, 2019

LibbyBot commented May 15, 2019

LibbyBot commented May 16, 2019

LibbyBot commented May 16, 2019

LibbyBot commented May 16, 2019

acdemyers commented May 16, 2019

LibbyBot commented May 16, 2019

LibbyBot commented May 16, 2019

LibbyBot commented May 16, 2019

acdemyers commented May 16, 2019

LibbyBot commented May 16, 2019

LibbyBot commented May 16, 2019

LibbyBot commented May 16, 2019

LibbyBot commented May 17, 2019