Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init frontend and create home page #17

Merged
merged 3 commits into from
Feb 11, 2022
Merged

init frontend and create home page #17

merged 3 commits into from
Feb 11, 2022

Conversation

jimmy1wu
Copy link
Contributor

@jimmy1wu jimmy1wu commented Feb 11, 2022 •
edited
Loading

for #13

home page:
image

@jimmy1wu jimmy1wu added the front-end Front-end UI of game label Feb 11, 2022
pgunapal
pgunapal requested changes Feb 11, 2022
View reviewed changes
Copy link
Member

@pgunapal pgunapal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a one comment, to add the licence headers to .html,.js, and .tsx files.

client/public/index.html Show resolved Hide resolved
@jimmy1wu jimmy1wu requested a review from pgunapal February 11, 2022 21:39
pgunapal
pgunapal approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@pgunapal pgunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmy1wu jimmy1wu merged commit cb5d460 into main Feb 11, 2022
@jimmy1wu jimmy1wu deleted the issue_13 branch February 11, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgunapal pgunapal pgunapal approved these changes

Assignees
No one assigned
Labels
front-end Front-end UI of game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmy1wu @pgunapal