Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix player name #38

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix player name #38

merged 2 commits into from
Apr 6, 2022

Conversation

jimmy1wu
Copy link
Contributor

@jimmy1wu jimmy1wu commented Apr 6, 2022

  • need to encode player name in url when redirecting
  • player name must be at least 1 char and disable spellcheck

@jimmy1wu jimmy1wu requested a review from pgunapal April 6, 2022 17:44
pgunapal
pgunapal approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@pgunapal pgunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmy1wu jimmy1wu merged commit 524c601 into main Apr 6, 2022
@jimmy1wu jimmy1wu deleted the fixPlayerName branch April 6, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgunapal pgunapal pgunapal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmy1wu @pgunapal