Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search functionality to leaderboard #80

Merged
merged 1 commit into from
May 13, 2022
Merged

add search functionality to leaderboard #80

merged 1 commit into from
May 13, 2022

Conversation

jimmy1wu
Copy link
Contributor

for #65

added a new search box on the top right of the leaderboard table. searches are case insensitive and will return all results which contain the search string (doesn't matter if search string matches on the start, end, or middle of the player name).

no search:
image

search for players with the letter o in their name:
image

show all of jimmy's results
image

no matches
image

@jimmy1wu jimmy1wu requested a review from pgunapal May 13, 2022 20:13
Copy link
Member

@pgunapal pgunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmy1wu jimmy1wu merged commit 2ce11d7 into main May 13, 2022
@jimmy1wu jimmy1wu deleted the issue_65 branch May 13, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants