Fix comparison methods for python3 #1537
Conversation
See https://portingguide.readthedocs.io/en/latest/comparisons.html#rich-comparisons for an explaination of why it was broken.
|
Thanks @nils-van-zuijlen . Initially it might be worth a quick read of #1514 and some of the discussion linked to from #1506 . Do you fancy targetting our 0.10 branch? I'd started trying to get Python 3 builds working in Travis, if you fancy continuing that as it still needs some work (working on the principal we should probably have some tests to catch these failures in future)... |
functools.total_ordering is only available from python 3.2 fix flake8 formatting
|
All Mac builds are failing for some reason outside your control. 😞 |
peternewman
changed the title
|
Yes, I saw it. Apparently GitHub syncronisation failed 😢 |
Looks like it's progressing third time around... |
|
Now it works ! |
|
I rebased my commits for 0.10 in #1538 |
See https://portingguide.readthedocs.io/en/latest/comparisons.html#rich-comparisons for an explaination of why it was broken.
In particular, I was stuck with a bug in the
_Eventclass because heaps are ordered and I wanted to add multiple events to it, which failed because they had no suitable comparison functions.