This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Simplify release sidebar position numbering approach #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mellifluous-eclair-326dcd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…pdating. Signed-off-by: Michael Robinson <merobi@gmail.com>
merobi-hub
force-pushed
the
releases/autogenerate-positions
branch
from
c6e31d0 to
446fc70
Compare
merobi-hub
changed the title
|
It's a great idea and looks like it's working 🚀 Maybe 10k is a better idea? Seems more relevant in decimal world. |
Signed-off-by: Michael Robinson <merobi@gmail.com>
|
@JDarDagran cool. works for me -- made the change. |
JDarDagran
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are using a custom script to iterate through the release files and update position numbers so the releases display in order in the sidebar. This adds complexity and an extra step to the process. It also complicates any future effort to automate the process of adding releases to the docs.
This changes release sidebar position numbers so the oldest release has a much larger number -- instead of using 1 for the most recent release. I went with 10000. Floats are supported, however, so in the unlikely event we "run out" of integers, we can start using them.