fix(security): avoid pass plaintext sensitive data to the frontend#16
Merged
PIKACHUIM merged 3 commits intoOpenListTeam:mainfrom Jun 22, 2025
Merged
fix(security): avoid pass plaintext sensitive data to the frontend#16PIKACHUIM merged 3 commits intoOpenListTeam:mainfrom
PIKACHUIM merged 3 commits intoOpenListTeam:mainfrom
Conversation
Contributor
hcrgm
commented
Jun 14, 2025
hcrgm
commented
- pass sensitive data with URL hash instead of URL query
- encode sensitive data by JSON then encode to base64
- remove debug logs
- remove sensitive data from browser history, tested in Chrome (not work in Firefox)
- avoid return api keys to the frontend when server_use is "true" and error occurred in api request
Member
|
Thank you for your PR. Since your last PR submission, there have been significant changes to this repo, and merging submissions may require a lot of work. If you can rebase your modifications to the latest version, merging will be accelerated. Here are some changes:
Thank you again for your contribution |
Member
|
I have moved the JS code in the index.html file that you modified to public/static/test.js, and it may require you to rebase it |
- pass sensitive data with URL hash instead of URL query - encode sensitive data by JSON then encode to base64 - remove debug logs - remove sensitive data from browser history, tested in Chrome (not work in Firefox) - avoid return api keys to the frontend when server_use is "true" and error occurred in api request
Contributor
Author
I have merged the latest code. Currently tested with baiduyun_ob. It should be OK to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.