feat(server): add error page and status code (#1099)

xrgzs · web-flow · commit b04677b806b9 · 2025-08-19T15:18:12.000+08:00
diff --git a/server/common/common.go b/server/common/common.go
@@ -2,6 +2,9 @@ package common
 
 import (
 	"context"
+	"fmt"
+	"html"
+	"net/http"
 	"strings"
 
 	"github.com/OpenListTeam/OpenList/v4/cmd/flags"
@@ -38,6 +41,41 @@ func ErrorResp(c *gin.Context, err error, code int, l ...bool) {
 	//c.Abort()
 }
 
+// ErrorPage is used to return error page HTML.
+// It also returns standard HTTP status code.
+// @param l: if true, log error
+func ErrorPage(c *gin.Context, err error, code int, l ...bool) {
+
+	if len(l) > 0 && l[0] {
+		if flags.Debug || flags.Dev {
+			log.Errorf("%+v", err)
+		} else {
+			log.Errorf("%v", err)
+		}
+	}
+
+	codes := fmt.Sprintf("%d %s", code, http.StatusText(code))
+
+	html := fmt.Sprintf(`<!DOCTYPE html>
+<html lang="en">
+	<head>
+		<meta charset="utf-8" />
+		<meta name="viewport" content="width=device-width, initial-scale=1" />
+		<meta name="color-scheme" content="dark light" />
+		<meta name="robots" content="noindex" />
+		<title>%s</title>
+	</head>
+	<body>
+		<h1>%s</h1>
+		<hr>
+		<p>%s</p>
+	</body>
+</html>`,
+		codes, codes, html.EscapeString(hidePrivacy(err.Error())))
+	c.Data(code, "text/html; charset=utf-8", []byte(html))
+	c.Abort()
+}
+
 func ErrorWithDataResp(c *gin.Context, err error, code int, data interface{}, l ...bool) {
 	if len(l) > 0 && l[0] {
 		if flags.Debug || flags.Dev {
diff --git a/server/handles/archive.go b/server/handles/archive.go
@@ -320,7 +320,7 @@ func ArchiveDown(c *gin.Context) {
 	filename := stdpath.Base(innerPath)
 	storage, err := fs.GetStorage(archiveRawPath, &fs.GetStoragesArgs{})
 	if err != nil {
-		common.ErrorResp(c, err, 500)
+		common.ErrorPage(c, err, 500)
 		return
 	}
 	if common.ShouldProxy(storage, filename) {
@@ -340,7 +340,7 @@ func ArchiveDown(c *gin.Context) {
 			InnerPath: innerPath,
 		})
 		if err != nil {
-			common.ErrorResp(c, err, 500)
+			common.ErrorPage(c, err, 500)
 			return
 		}
 		redirect(c, link)
@@ -354,7 +354,7 @@ func ArchiveProxy(c *gin.Context) {
 	filename := stdpath.Base(innerPath)
 	storage, err := fs.GetStorage(archiveRawPath, &fs.GetStoragesArgs{})
 	if err != nil {
-		common.ErrorResp(c, err, 500)
+		common.ErrorPage(c, err, 500)
 		return
 	}
 	if canProxy(storage, filename) {
@@ -370,7 +370,7 @@ func ArchiveProxy(c *gin.Context) {
 			InnerPath: innerPath,
 		})
 		if err != nil {
-			common.ErrorResp(c, err, 500)
+			common.ErrorPage(c, err, 500)
 			return
 		}
 		proxy(c, link, file, storage.GetStorage().ProxyRange)
@@ -413,7 +413,7 @@ func ArchiveInternalExtract(c *gin.Context) {
 		InnerPath: innerPath,
 	})
 	if err != nil {
-		common.ErrorResp(c, err, 500)
+		common.ErrorPage(c, err, 500)
 		return
 	}
 	fileName := stdpath.Base(innerPath)
diff --git a/server/handles/down.go b/server/handles/down.go
@@ -26,7 +26,7 @@ func Down(c *gin.Context) {
 	filename := stdpath.Base(rawPath)
 	storage, err := fs.GetStorage(rawPath, &fs.GetStoragesArgs{})
 	if err != nil {
-		common.ErrorResp(c, err, 500)
+		common.ErrorPage(c, err, 500)
 		return
 	}
 	if common.ShouldProxy(storage, filename) {
@@ -40,7 +40,7 @@ func Down(c *gin.Context) {
 			Redirect: true,
 		})
 		if err != nil {
-			common.ErrorResp(c, err, 500)
+			common.ErrorPage(c, err, 500)
 			return
 		}
 		redirect(c, link)
@@ -52,7 +52,7 @@ func Proxy(c *gin.Context) {
 	filename := stdpath.Base(rawPath)
 	storage, err := fs.GetStorage(rawPath, &fs.GetStoragesArgs{})
 	if err != nil {
-		common.ErrorResp(c, err, 500)
+		common.ErrorPage(c, err, 500)
 		return
 	}
 	if canProxy(storage, filename) {
@@ -67,7 +67,7 @@ func Proxy(c *gin.Context) {
 			Type:   c.Query("type"),
 		})
 		if err != nil {
-			common.ErrorResp(c, err, 500)
+			common.ErrorPage(c, err, 500)
 			return
 		}
 		proxy(c, link, file, storage.GetStorage().ProxyRange)
@@ -89,7 +89,7 @@ func redirect(c *gin.Context, link *model.Link) {
 		}
 		link.URL, err = utils.InjectQuery(link.URL, query)
 		if err != nil {
-			common.ErrorResp(c, err, 500)
+			common.ErrorPage(c, err, 500)
 			return
 		}
 	}
@@ -106,7 +106,7 @@ func proxy(c *gin.Context, link *model.Link, file model.Obj, proxyRange bool) {
 		}
 		link.URL, err = utils.InjectQuery(link.URL, query)
 		if err != nil {
-			common.ErrorResp(c, err, 500)
+			common.ErrorPage(c, err, 500)
 			return
 		}
 	}
@@ -149,9 +149,9 @@ func proxy(c *gin.Context, link *model.Link, file model.Obj, proxyRange bool) {
 		log.Errorf("%s %s local proxy error: %+v", c.Request.Method, c.Request.URL.Path, err)
 	} else {
 		if statusCode, ok := errors.Unwrap(err).(net.ErrorHttpStatusCode); ok {
-			common.ErrorResp(c, err, int(statusCode), true)
+			common.ErrorPage(c, err, int(statusCode), true)
 		} else {
-			common.ErrorResp(c, err, 500, true)
+			common.ErrorPage(c, err, 500, true)
 		}
 	}
 }
diff --git a/server/middlewares/down.go b/server/middlewares/down.go
@@ -27,7 +27,7 @@ func Down(verifyFunc func(string, string) error) func(c *gin.Context) {
 		meta, err := op.GetNearestMeta(rawPath)
 		if err != nil {
 			if !errors.Is(errors.Cause(err), errs.MetaNotFound) {
-				common.ErrorResp(c, err, 500, true)
+				common.ErrorPage(c, err, 500, true)
 				return
 			}
 		}
@@ -37,7 +37,7 @@ func Down(verifyFunc func(string, string) error) func(c *gin.Context) {
 			s := c.Query("sign")
 			err = verifyFunc(rawPath, strings.TrimSuffix(s, "/"))
 			if err != nil {
-				common.ErrorResp(c, err, 401)
+				common.ErrorPage(c, err, 401)
 				c.Abort()
 				return
 			}

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ func Down(c *gin.Context) {`
`26`	`26`	`filename := stdpath.Base(rawPath)`
`27`	`27`	`storage, err := fs.GetStorage(rawPath, &fs.GetStoragesArgs{})`
`28`	`28`	`if err != nil {`
`29`		`- common.ErrorResp(c, err, 500)`
	`29`	`+ common.ErrorPage(c, err, 500)`
`30`	`30`	`return`
`31`	`31`	`}`
`32`	`32`	`if common.ShouldProxy(storage, filename) {`
`@@ -40,7 +40,7 @@ func Down(c *gin.Context) {`
`40`	`40`	`Redirect: true,`
`41`	`41`	`})`
`42`	`42`	`if err != nil {`
`43`		`- common.ErrorResp(c, err, 500)`
	`43`	`+ common.ErrorPage(c, err, 500)`
`44`	`44`	`return`
`45`	`45`	`}`
`46`	`46`	`redirect(c, link)`
`@@ -52,7 +52,7 @@ func Proxy(c *gin.Context) {`
`52`	`52`	`filename := stdpath.Base(rawPath)`
`53`	`53`	`storage, err := fs.GetStorage(rawPath, &fs.GetStoragesArgs{})`
`54`	`54`	`if err != nil {`
`55`		`- common.ErrorResp(c, err, 500)`
	`55`	`+ common.ErrorPage(c, err, 500)`
`56`	`56`	`return`
`57`	`57`	`}`
`58`	`58`	`if canProxy(storage, filename) {`
`@@ -67,7 +67,7 @@ func Proxy(c *gin.Context) {`
`67`	`67`	`Type: c.Query("type"),`
`68`	`68`	`})`
`69`	`69`	`if err != nil {`
`70`		`- common.ErrorResp(c, err, 500)`
	`70`	`+ common.ErrorPage(c, err, 500)`
`71`	`71`	`return`
`72`	`72`	`}`
`73`	`73`	`proxy(c, link, file, storage.GetStorage().ProxyRange)`
`@@ -89,7 +89,7 @@ func redirect(c gin.Context, link model.Link) {`
`89`	`89`	`}`
`90`	`90`	`link.URL, err = utils.InjectQuery(link.URL, query)`
`91`	`91`	`if err != nil {`
`92`		`- common.ErrorResp(c, err, 500)`
	`92`	`+ common.ErrorPage(c, err, 500)`
`93`	`93`	`return`
`94`	`94`	`}`
`95`	`95`	`}`
`@@ -106,7 +106,7 @@ func proxy(c gin.Context, link model.Link, file model.Obj, proxyRange bool) {`
`106`	`106`	`}`
`107`	`107`	`link.URL, err = utils.InjectQuery(link.URL, query)`
`108`	`108`	`if err != nil {`
`109`		`- common.ErrorResp(c, err, 500)`
	`109`	`+ common.ErrorPage(c, err, 500)`
`110`	`110`	`return`
`111`	`111`	`}`
`112`	`112`	`}`
`@@ -149,9 +149,9 @@ func proxy(c gin.Context, link model.Link, file model.Obj, proxyRange bool) {`
`149`	`149`	`log.Errorf("%s %s local proxy error: %+v", c.Request.Method, c.Request.URL.Path, err)`
`150`	`150`	`} else {`
`151`	`151`	`if statusCode, ok := errors.Unwrap(err).(net.ErrorHttpStatusCode); ok {`
`152`		`- common.ErrorResp(c, err, int(statusCode), true)`
	`152`	`+ common.ErrorPage(c, err, int(statusCode), true)`
`153`	`153`	`} else {`
`154`		`- common.ErrorResp(c, err, 500, true)`
	`154`	`+ common.ErrorPage(c, err, 500, true)`
`155`	`155`	`}`
`156`	`156`	`}`
`157`	`157`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ func Down(verifyFunc func(string, string) error) func(c *gin.Context) {`
`27`	`27`	`meta, err := op.GetNearestMeta(rawPath)`
`28`	`28`	`if err != nil {`
`29`	`29`	`if !errors.Is(errors.Cause(err), errs.MetaNotFound) {`
`30`		`- common.ErrorResp(c, err, 500, true)`
	`30`	`+ common.ErrorPage(c, err, 500, true)`
`31`	`31`	`return`
`32`	`32`	`}`
`33`	`33`	`}`
`@@ -37,7 +37,7 @@ func Down(verifyFunc func(string, string) error) func(c *gin.Context) {`
`37`	`37`	`s := c.Query("sign")`
`38`	`38`	`err = verifyFunc(rawPath, strings.TrimSuffix(s, "/"))`
`39`	`39`	`if err != nil {`
`40`		`- common.ErrorResp(c, err, 401)`
	`40`	`+ common.ErrorPage(c, err, 401)`
`41`	`41`	`c.Abort()`
`42`	`42`	`return`
`43`	`43`	`}`