feat(server): add error page and status code #1099
Merged
+53
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies error handling for web endpoints to return HTML error pages with proper HTTP status codes instead of JSON responses. The change affects download and archive endpoints (/d/*path, /p/*path, /ad/*path, /ap/*path, /ae/*path) while preserving API behavior.
- Replaces
common.ErrorRespcalls withcommon.ErrorPagein download and archive handlers - Adds new
ErrorPagefunction that generates HTML error pages with proper status codes - Maintains existing error logging and privacy filtering functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/common/common.go | Adds ErrorPage function to generate HTML error pages with status codes |
| server/handles/down.go | Updates download handlers to use ErrorPage instead of ErrorResp |
| server/handles/archive.go | Updates archive handlers to use ErrorPage instead of ErrorResp |
| server/middlewares/down.go | Updates middleware error handling to use ErrorPage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
PIKACHUIM
approved these changes
Aug 19, 2025
KirCute
added a commit
to KirCute/OpenList
that referenced
this pull request
Aug 19, 2025
xrgzs
pushed a commit
that referenced
this pull request
Aug 19, 2025
lyy2005a2
pushed a commit
to lyy2005a2/OpenList
that referenced
this pull request
Aug 24, 2025
* 重构（docker）：减小docker镜像大小(2) * feat（share）：支持更安全的文件共享(28) * feat（server）：添加错误页面和状态码(2)重复server/handles/archive.go(1)重复server/middlewares/down.go(1) * feat（123_open）：添加选项 (4) * feat（服务器）：将 OpenListTeam#1099 改编为 OpenListTeam#991 (0)重复(3)[server/handles/archive.go=server/handles/down.go=server/handles/sharing.go]
ForSourceCodeAnalysis
pushed a commit
to ForSourceCodeAnalysis/OpenList
that referenced
this pull request
Oct 4, 2025
ForSourceCodeAnalysis
pushed a commit
to ForSourceCodeAnalysis/OpenList
that referenced
this pull request
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #1086
Only modify the behavior of
/d/*path,/p/*path,/ad/*path,/ap/*path,/ae/*path.Not affect
/api.The API will always respond with a 200 status code, with the actual status code wrapped in a JSON object, like the previous response.
Some error status responses are still under discussion. Returning a
500status code for all errors may not be the most optimal approach.