Skip to content

Conversation

@KirCute
Copy link
Member

@KirCute KirCute commented Sep 14, 2025

Description / 描述

增加从123123_share两个驱动获取到的文件的哈希信息。

Motivation and Context / 背景

Closes #1275

How Has This Been Tested? / 测试

Checklist / 检查清单

  • I have read the CONTRIBUTING document.
    我已阅读 CONTRIBUTING 文档。
  • I have formatted my code with go fmt or prettier.
    我已使用 go fmtprettier 格式化提交的代码。
  • I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
    我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
  • I have requested review from relevant code authors using the "Request review" feature when applicable.
    我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
  • I have updated the repository accordingly (If it’s needed).
    我已相应更新了相关仓库(若适用)。

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds hash information support to the 123 and 123_share drivers by implementing the GetHash() method to return MD5 hash information using the file's Etag field.

  • Updates GetHash() method to return actual hash information instead of empty struct
  • Uses the existing Etag field as the MD5 hash value for both drivers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
drivers/123_share/types.go Implements GetHash() to return MD5 hash info using Etag field
drivers/123/types.go Implements GetHash() to return MD5 hash info using Etag field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@xrgzs xrgzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etag 我之前遇到与实际 md5 不等的情况,但为了实现跨盘秒传,且大多数情况下 etag 都等于 md5,LGTM

@KirCute KirCute merged commit 61a8ed5 into OpenListTeam:main Sep 14, 2025
14 checks passed
@KirCute KirCute deleted the feat/123-rapid branch September 14, 2025 13:37
ForSourceCodeAnalysis pushed a commit to ForSourceCodeAnalysis/OpenList that referenced this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 123秒传需求

2 participants