feat(drivers): add halalcloud_open driver #1430

zzzhr1990 · 2025-10-05T17:20:53Z

Description / 描述

新增清真云的Open驱动，支持用户级ClientID/ClientSecret，无需登录
支持文件直链下载(302)
支持新的文件上传

Motivation and Context / 背景

支持文件上传

Closes #1255

How Has This Been Tested? / 测试

Checklist / 检查清单

I have read the CONTRIBUTING document.
我已阅读 CONTRIBUTING 文档。
I have formatted my code with go fmt or prettier.
我已使用 go fmt 或 prettier 格式化提交的代码。
I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
I have requested review from relevant code authors using the "Request review" feature when applicable.
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
I have updated the repository accordingly (If it’s needed).
我已相应更新了相关仓库（若适用）。
- OpenList-Frontend #XXXX
- OpenList-Docs #XXXX

jyxjjj

我们还不准备升级Go版本到24

Copilot

Pull Request Overview

This PR adds a new HalalCloud Open driver that supports user-level ClientID/ClientSecret authentication without requiring login, provides direct file download with 302 redirects, and implements file upload functionality to fix issue #1255.

Adds complete HalalCloudOpen driver implementation with SDK-based API integration
Implements file operations (list, upload, download, move, copy, rename, delete) and direct link generation
Integrates authentication using client credentials and refresh tokens with automatic token management

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.

File	Description
go.mod	Updates Go version and adds HalalCloud SDK dependency
drivers/halalcloud_open/*.go	Complete driver implementation including utilities, file operations, upload handling, and API interfaces
drivers/all.go	Registers the new HalalCloudOpen driver

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

drivers/halalcloud_open/utils.go

drivers/halalcloud_open/obj_file.go

drivers/halalcloud_open/halalcloud_upload.go

drivers/halalcloud_open/driver_curd_impl.go

jyxjjj · 2025-10-06T01:53:54Z

我们使用了logrus，且代码中部分日志实际上为DEBUG级，并非需要直接输出为INFO。

Downgrade Go version from 1.24.2 to 1.23.4 Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

* Removed unnecessary comments * Downgraded the Go version to 1.23.4. * Not sure whether FileStream supports concurrent read and write operations, so currently using single-threaded upload to ensure safety. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

zzzhr1990

Not sure whether FileStream supports concurrent read and write operations, so currently using single-threaded upload to ensure safety.
Downgraded the Go version to 1.23.4.

Not sure whether FileStream supports concurrent read and write operations, so currently using single-threaded upload to ensure safety. Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

Change required for RefreshToken, If using a personal API approach, the RefreshToken is not required. Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

zzzhr1990

change RefreshToken required to false.

drivers/halalcloud_open/halalcloud_upload.go

zzzhr1990 · 2025-10-06T11:05:15Z

golang 版本已经降至 1.23.4

go.mod

drivers/halalcloud_open/meta.go

drivers/halalcloud_open/driver_init.go

drivers/halalcloud_open/halalcloud_upload.go

drivers/halalcloud_open/meta.go

drivers/halalcloud_open/halalcloud_upload.go

drivers/halalcloud_open/meta.go

drivers/halalcloud_open/driver.go

Copilot

Pull Request Overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (4)

drivers/halalcloud_open/utils.go:1

Parameter name 'preix' should be 'prefix'.

package halalcloudopen

drivers/halalcloud_open/utils.go:1

Parameter name 'preix' should be 'prefix'.

package halalcloudopen

drivers/halalcloud_open/utils.go:1

Variable name 'preix' should be 'prefix'.

package halalcloudopen

drivers/halalcloud_open/utils.go:1

Variable name 'preix' should be 'prefix'.

package halalcloudopen

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

drivers/halalcloud_open/halalcloud_upload.go

drivers/halalcloud_open/driver_init.go

KirCute

Copilot 说的 timeout 拼写问题可以改一下，别的我这看没问题了

jyxjjj · 2025-10-10T13:59:10Z

拼写错误有好几个的，都改掉

drivers/halalcloud_open/driver_get_link.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

zzzhr1990 · 2025-10-11T12:00:03Z

Copilot 说的 timeout 拼写问题可以改一下，别的我这看没问题了
感谢已经修复

zzzhr1990 · 2025-10-11T12:01:04Z

拼写错误有好几个的，都改掉
已修改

drivers/halalcloud_open/halalcloud_upload.go

drivers/halalcloud_open/utils.go

drivers/halalcloud_open/halalcloud_upload.go

drivers/halalcloud_open/common.go

ILoveScratch2 · 2025-10-13T14:07:35Z

其实上面都是细节问题，不改也行

zzzhr1990 · 2025-10-13T14:33:34Z

其实上面都是细节问题，不改也行

指针的问题已经修改了，sync.Map 的那个我还是觉得可能 sync.Map 相对于Map和锁更安全些（可能在写值的时候会忘记加锁）毕竟 sync.Map 能出的问题是类型转换失败，而这个很容易复现和排查。

新增清真云Open驱动，支持最新的轻量SDK

e935266

zzzhr1990 changed the title ~~feat(driver): 新增清真云Open驱动，支持最新的轻量SDK~~ feat(driver): Add Halalcloud Open driver, fix #1255 Oct 5, 2025

Merge branch 'main' into halal-cloud-new-sdk

602898c

jyxjjj requested changes Oct 6, 2025

View reviewed changes

jyxjjj requested a review from Copilot October 6, 2025 01:43

Copilot AI reviewed Oct 6, 2025

View reviewed changes

zzzhr1990 and others added 2 commits October 6, 2025 16:02

Change Go version in go.mod

19c9f57

Downgrade Go version from 1.24.2 to 1.23.4 Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

zzzhr1990 commented Oct 6, 2025

View reviewed changes

zzzhr1990 requested a review from jyxjjj October 6, 2025 08:09

KirCute and others added 4 commits October 6, 2025 16:53

feat(halalcloud_open): support disk usage

9531044

Merge branch 'main' into halal-cloud-new-sdk

1299108

Set useSingleUpload to true for upload safety

6d22e7a

Not sure whether FileStream supports concurrent read and write operations, so currently using single-threaded upload to ensure safety. Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

Update meta.go

850a77c

Change required for RefreshToken, If using a personal API approach, the RefreshToken is not required. Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

zzzhr1990 commented Oct 6, 2025

View reviewed changes

KirCute reviewed Oct 6, 2025

View reviewed changes

drivers/halalcloud_open/halalcloud_upload.go Outdated Show resolved Hide resolved

KirCute changed the title ~~feat(driver): Add Halalcloud Open driver, fix #1255~~ feat(driver): add halalcloud_open driver Oct 6, 2025

KirCute changed the title ~~feat(driver): add halalcloud_open driver~~ feat(drivers): add halalcloud_open driver Oct 6, 2025

remove debug logs

c3e95f8

zzzhr1990 added 2 commits October 7, 2025 11:30

Merge branch 'main' into halal-cloud-new-sdk

9e3dc83

bump halalcloud SDK version

039e933

ILoveScratch2 reviewed Oct 9, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

jyxjjj requested review from KirCute and j2rong4cn October 9, 2025 16:22

KirCute requested changes Oct 10, 2025

View reviewed changes

fix unnecessary params

84a45dd

zzzhr1990 requested review from KirCute and Copilot October 10, 2025 12:59

Copilot AI reviewed Oct 10, 2025

View reviewed changes

KirCute previously approved these changes Oct 10, 2025

View reviewed changes

j2rong4cn reviewed Oct 11, 2025

View reviewed changes

drivers/halalcloud_open/driver_get_link.go Show resolved Hide resolved

Update drivers/halalcloud_open/driver_init.go

8511cd4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: zzzhr1990 <zzzhr@hotmail.com>

zzzhr1990 dismissed KirCute’s stale review via 8511cd4 October 11, 2025 11:41

Fixed spelling errors; changed hardcoded retry parameters to constants.

99c96eb

KirCute previously approved these changes Oct 11, 2025

View reviewed changes

jyxjjj previously approved these changes Oct 11, 2025

View reviewed changes

j2rong4cn reviewed Oct 11, 2025

View reviewed changes

drivers/halalcloud_open/halalcloud_upload.go Show resolved Hide resolved

ILoveScratch2 reviewed Oct 11, 2025

View reviewed changes

drivers/halalcloud_open/utils.go Outdated Show resolved Hide resolved

drivers/halalcloud_open/halalcloud_upload.go Show resolved Hide resolved

drivers/halalcloud_open/common.go Show resolved Hide resolved

ILoveScratch2 previously approved these changes Oct 13, 2025

View reviewed changes

remove pointer in get link function in utils.go

bb4fdcb

zzzhr1990 dismissed stale reviews from ILoveScratch2, jyxjjj, and KirCute via bb4fdcb October 13, 2025 14:27

ILoveScratch2 approved these changes Oct 13, 2025

View reviewed changes

jyxjjj merged commit fb5094f into OpenListTeam:main Oct 14, 2025

zzzhr1990 deleted the halal-cloud-new-sdk branch October 14, 2025 09:26

Uh oh!

feat(drivers): add halalcloud_open driver #1430

feat(drivers): add halalcloud_open driver #1430

Uh oh!

Conversation

zzzhr1990 commented Oct 5, 2025 • edited by KirCute Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description / 描述

Motivation and Context / 背景

How Has This Been Tested? / 测试

Checklist / 检查清单

Uh oh!

jyxjjj left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyxjjj commented Oct 6, 2025

Uh oh!

zzzhr1990 left a comment

Choose a reason for hiding this comment

Uh oh!

zzzhr1990 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zzzhr1990 commented Oct 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KirCute left a comment

Choose a reason for hiding this comment

Uh oh!

jyxjjj commented Oct 10, 2025

Uh oh!

Uh oh!

zzzhr1990 commented Oct 11, 2025

Uh oh!

zzzhr1990 commented Oct 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ILoveScratch2 commented Oct 13, 2025

Uh oh!

zzzhr1990 commented Oct 13, 2025

Uh oh!

Reviewers

zzzhr1990 commented Oct 5, 2025 •

edited by KirCute

Loading