fix(link): correct link cache mode bitwise comparison #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
…k checks Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the bitwise comparison logic for link cache mode flags. The original code incorrectly compared the bitwise AND result against the literal value 1, which would fail for the LinkCacheUA flag (value 2). The fix correctly compares against the actual flag constants.
- Corrects bitwise AND comparison for
LinkCacheIPflag check - Corrects bitwise AND comparison for
LinkCacheUAflag check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jyxjjj
approved these changes
Nov 13, 2025
Member
|
其实一般做位运算都不和其他值对比，而是异或后和期望值对比，问题倒是没问题但是可能难以维护。我先合有问题再说吧。 |
This comment was marked as spam.
This comment was marked as spam.
Member
请不要提无关问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / 描述
更正链接缓存模式的位运算
Motivation and Context / 背景
Fix https://github.com/OpenListTeam/OpenList/pull/1498/files#r2521239767
Relates to #1498
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库（若适用）。