Skip to content

Conversation

@jyxjjj
Copy link
Member

@jyxjjj jyxjjj commented Nov 25, 2025

Description

Emergency fix for #1423

Motivation and Context

The original author created a duplicate variable, which will cause an error.

Actions has already failed: https://github.com/OpenListTeam/OpenList/actions/runs/19657414048

Due to the original author did not respond promptly, this PR aims to fix this issue immediately. Whether it will meet the original requirements is currently unknown.

Relates to #1423

How Has This Been Tested?

Checklist

  • I have read the CONTRIBUTING document.
  • I have formatted my code with go fmt or prettier.
  • I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
  • I have requested review from relevant code authors using the "Request review" feature when applicable.
  • I have updated the repository accordingly (If it’s needed).

@jyxjjj jyxjjj requested a review from PIKACHUIM November 25, 2025 04:00
@jyxjjj
Copy link
Member Author

jyxjjj commented Nov 25, 2025

@jyxjjj
Copy link
Member Author

jyxjjj commented Nov 25, 2025

We should merge immediately since BETA has already been created in #1423.
Also, @ImoutoHeaven should check again. We might need to create a new pull request to fix the entire issue, or leave a comment if this PR resolves it.

@PIKACHUIM PIKACHUIM merged commit aa22884 into main Nov 25, 2025
14 checks passed
@jyxjjj jyxjjj deleted the fix-1423 branch November 25, 2025 04:23
@ImoutoHeaven
Copy link
Contributor

I apologize for the amateur mistake. I only deployed the Meilisearch search backend in the production environment and failed to run regression tests on other DB schemas. I mistook successful compilation for a successful deployment.

The PR I created aimed to solve the problem of the Meilisearch automatic indexing queue being flooded, but it is incomplete. It's missing the task queue enqueuing for the BuildIndex task. I plan to refine the Meilisearch task queue later to allow it to accept BuildIndex task submissions. At that time, I might reconsider the regression testing for the recursive folder automatic indexing feature.

Furthermore, the PR @jyxjjj submitted will not affect the functionality of the Meilisearch Task Queue, because once the Meilisearch search function is enabled, msInstance.EnqueueUpdate(parent, objs) queues the task and returns immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants