fix(pkg/aria2): use pointer receivers for Call methods #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the Call methods in httpCaller and websocketCaller to use pointer receivers instead of value receivers. This ensures that any modifications to the receiver's state within the method are preserved and aligns with Go best practices for methods that may modify receiver state.
jyxjjj
added
enhancement
go
PR: NOT-URGENT
PR: LOW-RISK
and removed
PR: NOT-URGENT
labels
ILoveScratch2
approved these changes
Nov 25, 2025
jyxjjj
changed the title
Member
|
这两个函数会改变接收器内部的值吗，或者说，如果它以前这么写一直都没有问题，为什么要改这个 |
Member
Author
其实不是改变的问题，是复制的问题，原来的写法应该属于1.20以前的语法，改的原因是vet对1.20后的代码检查更严格而已，其实属于chore，出问题的点在于sync.Once。但是复制变量与性能有关，所以用fix做title。 |
Member
看起来不会改字段值，但是改指针也没问题…… |
Member
|
我其实更担心一种很极端的情况，就是它故意用的非指针接收器，然后就是希望调用的时候把结构体复制一份，这样的事我在c++里干过。不过你们要是看了它没改里面的值的话那就没问题 |
KirCute
changed the title
KirCute
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / 描述
Changed the Call methods in httpCaller and websocketCaller to use pointer receivers instead of value receivers. This ensures that any modifications to the receiver's state within the method are preserved and aligns with Go best practices for methods that may modify receiver state.
Motivation and Context
How Has This Been Tested?
Checklist
I have read the CONTRIBUTING document.
I have formatted my code with
go fmtor prettier.I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
I have requested review from relevant code authors using the "Request review" feature when applicable.