Skip to content

Conversation

@Kuingsmile
Copy link
Member

change module name from alist-org/alist to OpenListTeam/OpenList

Copy link
Member

@jyxjjj jyxjjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接这样改的话没法跑起来 暂时不用关 有一些地方还有链接双斜杠问题 请修改 然后可以先等子项目发布完

@Kuingsmile
Copy link
Member Author

不用关 有一些地方还有链接双斜杠问题 请修改 然后可以先等

链接问题已修改

@eryajf
Copy link
Contributor

eryajf commented Jun 12, 2025

包名当中 v3 感觉没必要保留,可以一并换掉。

@eryajf
Copy link
Contributor

eryajf commented Jun 12, 2025

直接这样改的话没法跑起来 暂时不用关 有一些地方还有链接双斜杠问题 请修改 然后可以先等子项目发布完

直接修改应该没问题吧,我在本地测试了,全局替换,然后运行无影响。

@Kuingsmile
Copy link
Member Author

包名当中 v3 感觉没必要保留,可以一并换掉。

这个可以

@cxw620

This comment was marked as duplicate.

@eryajf
Copy link
Contributor

eryajf commented Jun 12, 2025

包名当中 v3 感觉没必要保留,可以一并换掉。

这个可以

我觉得留着比较好, 方便区分版本; 如果接下来直接发 v4.0.0 的话, 就改成 v4, 如果是发 v1.0.0 重新开始算版本号的话就 v1.

通常来说,发布release不应该变更包名。毕竟包名是一个全局引用的名字,经常跟随版本改包名,不是一个合理的操作。

@cxw620
Copy link
Member

cxw620 commented Jun 12, 2025

那么包名决定为 openlistteam/openlist 而不是 openlistteam/openlist/v3 了? #3 get blocked by this.

@cxw620
Copy link
Member

cxw620 commented Jun 12, 2025

cc @Kuingsmile 进展如何, 先不管包名吧, 发版再说

@Kuingsmile
Copy link
Member Author

cc @Kuingsmile 进展如何, 先不管包名吧, 发版再说

remove v3 in all module name

@cxw620
Copy link
Member

cxw620 commented Jun 12, 2025

cc @Kuingsmile 进展如何, 先不管包名吧, 发版再说

remove v3 in all module name

OK, let's have conflicts resolved and then squash merge the PR.

@BoYanZh
Copy link
Member

BoYanZh commented Jun 12, 2025

如果openlist直接从v1开始发布,那确实应该去掉包名里的/v3,如果以后的版本号从v3开始,那不应该去掉

@cxw620
Copy link
Member

cxw620 commented Jun 12, 2025

如果openlist直接从v1开始发布,那确实应该去掉包名里的/v3,如果以后的版本号从v3开始,那不应该去掉

See #2 (comment)

@cxw620
Copy link
Member

cxw620 commented Jun 12, 2025

cc @Kuingsmile 进展如何, 先不管包名吧, 发版再说

remove v3 in all module name

OK, let's have conflicts resolved and then squash merge the PR.

cc @Kuingsmile How's everything going?

@BoYanZh
Copy link
Member

BoYanZh commented Jun 12, 2025

如果openlist直接从v1开始发布,那确实应该去掉包名里的/v3,如果以后的版本号从v3开始,那不应该去掉

See #2 (comment)

https://go.dev/doc/modules/version-numbers#major-version 这不是golang中的最佳实践,不带/v4后缀直接发4.x.x版本会让人迷惑

@Kuingsmile
Copy link
Member Author

cc @Kuingsmile 进展如何, 先不管包名吧, 发版再说

remove v3 in all module name

OK, let's have conflicts resolved and then squash merge the PR.

cc @Kuingsmile How's everything going?

只有一些小的冲突了,除了config.yml,这个在合并的时候手动处理下吧,原文件的链接还是指向alist-org/alist的

@Kuingsmile

This comment was marked as resolved.

@cxw620

This comment was marked as resolved.

@Kuingsmile
Copy link
Member Author

cc @Kuingsmile 进展如何, 先不管包名吧, 发版再说

remove v3 in all module name

OK, let's have conflicts resolved and then squash merge the PR.

cc @Kuingsmile How's everything going?

只有一些小的冲突了,除了config.yml,这个在合并的时候手动处理下吧,原文件的链接还是指向alist-org/alist的

all conflicts are resolved

The final: fix build.sh and resolve conflicts, then we can merge this.

image
emmm 这一分钟前合并的这个 又conflict了

@cxw620
Copy link
Member

cxw620 commented Jun 12, 2025

image emmm 这一分钟前合并的这个 又conflict了

😂 CI / CD 那个自动测试先合, build.sh 里面还有 Docker 镜像构建里面也有涉及要改包名.

Copy link
Member

@cxw620 cxw620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI pass

@cxw620 cxw620 merged commit fdcc2f1 into OpenListTeam:main Jun 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants