-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(local): add directory size support #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution and the detailed explanation!
Because of these concerns, we believe the current approach needs further refinement to balance performance and reliability. We’d suggest:
Or packaging this as an optional setting for users who need it. We really appreciate your effort and welcome further improvements on this feature! |
|
Hello, thanks for the response!
I'm at the concussion that this implementation is already as performant as it can be, it already minimized the calculation which need to be done after the first initialization. As of reliability, I think it can be improved by listening to FS events, but I'm not sure if that work well with OpenList's way of implementing drivers. |
|
Hello, thank you for your contribution |
|
Thanks for the response, do we have any official performance testing methods? Or I just need to test it myself on large amount of files. |
|
Not yet. We will test the impact on performance ourselves. |
dezhishen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尝试使用ide的格式化代码功能,对代码进行格式化。
或者使用go fmt进行格式化
Signed-off-by: 我怎么就不是一只猫呢? <26274059+dezhishen@users.noreply.github.com>
…endless loop Signed-off-by: 我怎么就不是一只猫呢? <26274059+dezhishen@users.noreply.github.com>
Signed-off-by: 我怎么就不是一只猫呢? <26274059+dezhishen@users.noreply.github.com>
|
All review conversations must be marked as resolved before merging. |
ILoveScratch2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
性能可以就行
|
|
感謝各位大佬的協助! |
Hello to the OpenList community! This is an attempt to implement directory size for the local driver.
The size of directories are pre-calculated at initialization, and updated when user modify files through OpenList. Because of this if files are modified not using OpenList, the size displayed will likely be incorrect (can be fix by reloading the storage).
I don't know how well this would scale, so by default this option is set to
false.