perf(ftp): improve concurrent Link response; fix alias/local driver issues #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
太乱了， |
j2rong4cn
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on performance improvements for the FTP driver and fixes thread-safety issues in the alias and local drivers related to Link responses. The changes optimize concurrent Link handling while addressing issues with shared MFile objects that are not thread-safe.
- Optimizes FTP driver concurrent Link responses by removing custom FileReader and using direct range requests
- Fixes alias driver concurrent Link responses to prevent shared MFile thread-safety issues
- Corrects local driver thumbnail RangeReader size handling
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/utils/io.go | Refactors SyncClosers to use atomic operations and removes redundant error handling in CopyWithBuffer |
| internal/stream/util.go | Simplifies GetRangeReaderFromMFile to return proper interface type |
| internal/stream/stream.go | Refactors RangeReadReadAtSeeker to use sync.Map and simplifies caching logic |
| internal/op/fs.go | Adds MFile caching prevention logic for concurrent Link requests |
| internal/model/args.go | Removes redundant Close method from Link struct |
| drivers/ftp/driver.go | Completely rewrites FTP Link implementation for better concurrency |
| drivers/local/driver.go | Fixes ContentLength assignment for thumbnails |
| drivers/alias/driver.go | Adds proper Link copying to prevent shared MFile issues |
| Multiple driver files | Various cleanups and optimizations |
- Return actual error instead of nil in stream range read failure - Fix buffer copy bounds to prevent out-of-range access - Improve FTP FileReader loop termination and error propagation - Ensure partial reads are properly handled with context cancellation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要修改