fix(ftp): create a new connection for each download #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the FTP `Link` function was designed to reuse a single control connection for multiple download range requests. This approach could lead to connection conflicts and unpredictable behavior, as the FTP protocol is stateful and not designed for concurrent `RETR` commands on a single control connection. This commit changes the behavior to create a new control connection for each download range request. This ensures that each concurrent download task operates on a dedicated, isolated connection, improving the stability and reliability of multi-threaded FTP downloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the FTP
Linkfunction was designed to reuse a single control connectionfor multiple download range requests. This approach could lead to connection conflicts
and unpredictable behavior, as the FTP protocol is stateful and not designed for
concurrent
RETRcommands on a single control connection.This commit changes the behavior to create a new control connection for each
download range request. This ensures that each concurrent download task operates
on a dedicated, isolated connection, improving the stability and reliability of
multi-threaded FTP downloads.