Change atmosphere comp defaults from geopotential to Geodetic #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this behavior is different from GASP the form factors will always be calculated, but if they are present in the input deck the variable overriding will replace the calculated value with the one constant from the input deck. In gasp, these variables would only be calculated if the value wasn't set or if it was set to a value less than zero
Small fix to include components in the input search when setting inpu…
Co-authored-by: crecine <51181861+crecine@users.noreply.github.com>
…H = 100, Aircraft.Nacelle.AVG_LENGTH = 15 in gaspaero.py
…lure of TurbopropTest.test_turboprop() of test_custom_engine_model.py.
aviary/validation_cases/benchmark_tests/test_bench_multiengine.py
Outdated
Show resolved
Hide resolved
…n is due to a different bug, related to the design range: issue OpenMDAO#569. I have to adjust tolerances in order to pass unit tests.
jkirk5
approved these changes
Oct 16, 2024
Kenneth-T-Moore
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, the default option
h_definatmosphere.pyis switched togeodeticfromgeopotential. As a result, some validation data are updated. Currently there is no interface to alter the default value but in the future, we will have an atmosphere builder to allow users to alter this option.Some default values in
aviary/subsystems/aerodynamics/gasp_based/gaspaero.pyare changed in order to avoid some divide-by-zero warning messages.In
aviary/subsystems/propulsion/test/test_custom_engine_model.py, I have to modify thephase_infoby settingnum_segments = 3instead ofnum_segments = 2in order to avoid a unit test failure on GitHub. The unit test does not fail locally but only on GitHub. I had to try many different options to get it to work. This phenomenon happened before. I had to adjust tolerance a little bit. But this time it seemed that a constraint was violated in OpenMDAO and a constraint variable was reset. That might have resulted in aninforNaNsomewhere such that the unit test failed.Aircraft.Engine.GEOPOTENTIAL_ALTis not changed.We don't have a doc page on atmosphere.
Related Issues
Backwards incompatibilities
None
New Dependencies
None