copy data in case recorder output #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenneth-T-Moore
approved these changes
Jan 25, 2021
swryan
approved these changes
Jan 25, 2021
robfalck
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When getting constraints and design variables from a recorded case (e.g.
openmdao.recorders.case.Case.get_constraints), these are by default returned scaled. When accessing these outputs subsequently, they remain scaled. This PR simply ensures that a copy of the output is created before returning it.Related Issues
None
Backwards incompatibilities
It changes the behaviour of the case recorder as described above, but I would guess this is non-intentional behaviour.
New Dependencies
None