Fix to ensure that IPython is an optional import in the N2 viewer and connection viewer #1869
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swryan
approved these changes
Feb 2, 2021
Kenneth-T-Moore
approved these changes
Feb 2, 2021
DKilkenny
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes import error when loading n2_viewer.py and viewconns.py.
Since these are used in an
if notebookblock, the failure ofnotebook_modeto load IPython will ensure that those blocks are never executed if IPython is unavailable.Related Issues
Backwards incompatibilities
None
New Dependencies
None