Fix for bug when using InterpND to interpolate on 1D data. #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naylor-b
requested changes
Mar 5, 2021
| Initialize instance of interpolation class. | ||
| Initialize an InterpND object. | ||
|
|
||
| This object can be setup and used to interpolate on a curve or multi-dimensional table |
|
|
||
| For interpolation, specify values and points. | ||
|
|
||
| For spline evaulation, specifiy x_interp and either points or num_cp. |
| The points defining the regular grid in n dimensions. | ||
| For 1D interpolation, this can be an ndarray of table locations. | ||
| For table interpolation, it can be a tuple or an ndarray. If it is a tuple, it should | ||
| contain one ndarry for each table dimension. |
| @@ -113,8 +126,35 @@ def __init__(self, method="slinear", points=None, values=None, x_interp=None, ex | |||
| '%s.' % (method, all_m)) | |||
| self.extrapolate = extrapolate | |||
|
|
|||
| # The table points are always defined, either by specifying the number of the points | |||
| # directly. | |||
There was a problem hiding this comment.
This sentence has an 'either' but is it missing an 'or'?
|
All issues fixed. |
naylor-b
approved these changes
Mar 5, 2021
swryan
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for bug when using InterpND to interpolate on 1D data. It now works when you 1-dimensional arrays as any input. Formerly those arrays needed to be 2D.
Related Issues
Backwards incompatibilities
None
New Dependencies
None