Poem 047 Implementation 1

[andrewellis55]

Summary

Implementation 1 from POEM 047. Enables components to access their inputs and outputs without dependency on the problem metadata

Related Issues

• Resolves #PEOM 047

Backwards incompatibilities

None

New Dependencies

None

[naylor-b]

Can you refactor this as a test using a unittest.TestCase? That's how we do our testing in OpenMDAO. See any of our other test_* files for examples.

[andrewellis55]

Test Refactor should now be complete. I left it in the root folder as I'm not sure when you want to stash it (or even if it's a test you'd want to keep around).

[swryan]

since the code being tested is in openmdao/core/system.py, we would want this test in openmdao/core/tests/

[andrewellis55]

Just moved it there and renamed to match what it's testing (rather than just referencing the POEM number)

[swryan]

the if/else here is unnecessary?
this is equivalent to model_ref = self._problem_meta['model_ref']()?

[andrewellis55]

Whoops, yep, good point. Should be corrected now

[swryan]

actually, I think I see what you intended to do here... did you mean this?

        if self._problem_meta is not None:
            model_ref = self._problem_meta['model_ref']()
        else:
            model_ref = None

since the following statement expects model_ref to exist even if _problem_meta is None

[andrewellis55]

Sorry, I think I jumped to changing things without thinking about what I was doing. Yes, what you've written above is correct and should have the behavior I intended. I've updated the latest commit accordingly.

[swryan]

Thanks for your effort on this @andrewellis55 ... you can ignore the GitHub (OpenMDAO Test) failures, since we are having some issues with those right now, however it does look like there are a couple of PEP style violations that are getting flagged by openmdao/code_review/test_lint_peps.py

openmdao/code_review/test_lint_peps.py:LintTestCase.test_pep257 ... FAIL (00:00:3.69, 610 MB)
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/testflo/test.py", line 425, in _try_call
    func()
  File "/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/openmdao/code_review/test_lint_peps.py", line 121, in test_pep257
    self.fail('{} PEP 257 Failure(s):\n'.format(len(failures)) + '\n'.join(failures))
  File "/home/travis/miniconda/envs/PY3/lib/python3.7/unittest/case.py", line 693, in fail
    raise self.failureException(msg)
AssertionError: 1 PEP 257 Failure(s):
/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/openmdao/core/system.py:4832 in private method `_get_var_meta`:
        D202: No blank lines allowed after function docstring (found 1)
/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/openmdao/code_review/test_lint_peps.py:LintTestCase.test_pep8 ... FAIL (00:00:5.56, 610 MB)
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/testflo/test.py", line 425, in _try_call
    func()
  File "/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/openmdao/code_review/test_lint_peps.py", line 115, in test_pep8
    self.fail('{} PEP 8 Failure(s):\n'.format(report.total_errors) + '\n'.join(failures))
  File "/home/travis/miniconda/envs/PY3/lib/python3.7/unittest/case.py", line 693, in fail
    raise self.failureException(msg)
AssertionError: 3 PEP 8 Failure(s):
/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/openmdao/core/system.py:4848: [W293] blank line contains whitespace
^
/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/openmdao/core/system.py:4853: [E303] too many blank lines (2)
        if model_ref is not None:
        ^
/home/travis/miniconda/envs/PY3/lib/python3.7/site-packages/openmdao/core/system.py:5137: [W391] blank line at end of file

Thanks again for your contribution...

[andrewellis55]

@swryan Thanks for you help reviewing the changes. The PEP issues should be fixed with the latest commit